Repository navigation
Fix errors in the character table documentation - #6741
Merged
Merged
Conversation
fingolfin
added
topic: documentation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## master #6741 +/- ##
==========================================
+ Coverage 79.65% 79.68% +0.02%
==========================================
Files 684 684
Lines 295456 295462 +6
Branches 8686 8654 -32
==========================================
+ Hits 235351 235433 +82
+ Misses 58278 58202 -76
Partials 1827 1827 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Correct statements in the reference manual that contradict GAP's behaviour or mathematics: - IsDxLargeGroup: returns true for orders larger than DXLARGEGROUPORDER. - CharacterTableWithStoredGroup stores the new table on G, not tbl. - LinearCharacters: the p-modular case is the one for a group and p. - CharacterTableIsoclinic: N and Z are subgroups of H, not of H/Z. - SortedCharacterTable sets ClassPermutation on the result. - NormalSubgroupClassesInfo is stored in the table, and NormalSubgroupClasses reuses NormalSubgroups( G ), not a nonexistent normalSubgroups component. - InducedClassFunction: the monomorphism goes from G to H. - FrobeniusCharacterValue, SizeOfFieldOfDefinition: zeta is exp(2 pi i/(p^n-1)), not exp(p^n-1). - Permutation character: (1_H)^G, not (1_G)^H. - PermBounds: the conditions are pi(g) >= 0, not pi(g) > 0. - StoreFusion records the identifier of source, not destination. - FusionsAllowedByRestrictions: powermaps and subpowermaps belong to tbl and subtbl, not the other way round. - ConsiderKernels also returns false if a class has no image left; CheckFixedPoints keeps lists containing a possible fixed point; PossiblePowerMaps criterion 6 is checked for all characters, not kernels. - IsMonomialNumber: in condition 3 only q must be odd; condition 5 names q. - MinimalNonmonomialGroup returns fail, not false. - TestMonomial accepts a character or a group; Alpha counts distinct degrees; character tables in progress may lack even the class number. - Congruences, ConsiderKernels, ConsiderSmallerPowerMaps: the argument quick is optional. The errors were found by an audit of the manual using Claude Code, which also prepared the fixes; each was checked against current GAP. Assisted-by: Claude Code (Opus 5.5)
fingolfin
force-pushed
the
mh-claude/doc-facts-ctbl
branch
from
October 15, 2026 19:59
c277b77 to
943e67b
Compare
fingolfin
marked this pull request as ready for review
October 15, 2026 21:54
ThomasBreuer
approved these changes
Oct 20, 2026
| ## The <Ref Attr="ClassPermutation"/> value of <A>tbl</A> is changed if | ||
| ## necessary, see <Ref Attr="ClassPermutation"/>. | ||
| ## The <Ref Attr="ClassPermutation"/> value of the result is set, | ||
| ## see <Ref Attr="ClassPermutation"/>. |
Contributor
There was a problem hiding this comment.
This second reference is superfluous.
The sentence already links to ClassPermutation. Assisted-by: Generative AI
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Correct statements in the reference manual that contradict GAP's behaviour or mathematics:
The errors were found by an audit of the manual using Claude Code, which also prepared the fixes; each was checked against current GAP.
Assisted-by: Claude Code (Opus 5.5)
Based on PR #6731 which should be merged first, before this PR.