Repository navigation
chore(npm): update svelte (major) - #274
renovate[bot] wants to merge 1 commit into
Conversation
[High risk] The adapter-auto finding looks right: 8.0.1 peers on SvelteKit ^3.0.0-next.0 while the catalog keeps Kit 2.70.3, so the peer contract is broken. The package finding, that 3.0.2 no longer injects the default $lib alias, rests on the review's reading of the upstream code and should be confirmed before merge. Both are major steps in build tooling for the orchestration UI, so they rate high rather than critical, since a revert undoes them. Not approved: confidence 2/5 is below the threshold of 4 Findings
SummaryUpdates adapter-auto and svelte-package to new major versions.
Review context · 7 sources · 3/5 commands · 1 overlapping pull request
Reviews (1) · Last reviewed commit: "chore(npm): update svelte" · openai/gpt-6.1-sol · $0.23 |
| '@sveltejs/adapter-static': ^3.0.10 | ||
| '@sveltejs/kit': ^2.70.3 | ||
| '@sveltejs/package': ^2.5.8 | ||
| '@sveltejs/package': ^3.0.0 |
There was a problem hiding this comment.
Preserve $lib rewriting before upgrading svelte-package · compatibility
When packages/yucca-sdk/orchestration-ui/package.json:12 runs prepack, package 3.0.2 no longer injects the default $lib alias: its normalize_options only copies top-level config.alias and package imports. The new load-config loader receives Kit 2.70.3's svelte_config from the Vite plugin, with Kit options nested under kit, and the UI configuration supplies no top-level alias. Consequently imports such as $lib/options and $lib/services/backend.service in src/lib/components/backends/BackendsList.svelte:3–9 remain in the distributed components instead of becoming relative imports. The consuming web application then resolves these against its own $lib, breaking its build; its dependency on this library is at packages/web/package.json:40. This is a concrete packaging incompatibility beyond the advertised Node requirement.
Suggested fix
Retain @sveltejs/package ^2.5.8 and regenerate the lockfile until the packaging configuration is migrated and a packaged-output check confirms that library-internal $lib imports are rewritten to relative paths.
Prompt for a coding agent
Restore @sveltejs/package to ^2.5.8 in pnpm-workspace.yaml line 59 and regenerate pnpm-lock.yaml. Defer package 3 until the orchestration-ui configuration supplies aliases in the shape consumed by package 3. Add a regression check that prepack rewrites $lib/options and $lib/services/backend.service in distributed components to relative imports, and verify the web consumer builds against that output.
| '@opentelemetry/sdk-node': ^0.217.0 | ||
| '@playwright/test': 1.63.0 | ||
| '@sveltejs/adapter-auto': ^7.0.1 | ||
| '@sveltejs/adapter-auto': ^8.0.0 |
There was a problem hiding this comment.
Keep adapter-auto compatible with the installed SvelteKit major · compatibility
For the orchestration UI, this pairs adapter-auto 8.0.1 with SvelteKit 2.70.3: packages/yucca-sdk/orchestration-ui/package.json:52–53 consumes both catalog entries, and its svelte.config.js:1–9 instantiates this adapter. Upstream 8.0.0 explicitly requires Kit 3, and 8.0.1 declares the peer range ^3.0.0-next.0; the catalog still requires Kit 2. Strict peer-dependency installations therefore reject this dependency graph. The generated lockfile retaining Kit 2 does not satisfy that contract.
Suggested fix
Keep adapter-auto at ^7.0.1 and regenerate pnpm-lock.yaml until SvelteKit is migrated to version 3 in a coordinated update.
Prompt for a coding agent
In pnpm-workspace.yaml line 55, restore @sveltejs/adapter-auto to ^7.0.1 while @sveltejs/kit remains ^2.70.3. Regenerate pnpm-lock.yaml so orchestration-ui resolves adapter-auto 7.0.1 with Kit 2.
This PR contains the following updates:
^7.0.1→^8.0.0^2.5.8→^3.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
sveltejs/kit (@sveltejs/adapter-auto)
v8.0.1Compare Source
Patch Changes
v8.0.0Compare Source
Major Changes
Minor Changes
Patch Changes
fix: convert resolved adapter path to a file URL before importing, so builds work on Windows (#16618)
fix: allow prerelease versions of SvelteKit 3 to satisfy the peer dependency range (#16286)
Updated dependencies:
sveltejs/kit (@sveltejs/package)
v3.0.2Compare Source
Patch Changes
chore(deps): update dependency chokidar to v6 (#17514)
fix: exit after packaging when preprocessors leave resources running (#17497)
v3.0.1Compare Source
Patch Changes
sveltedependency range allows (#17330)v3.0.0Compare Source
Major Changes
Minor Changes
feat: warn when using a
.server.file or file inside aserverdirectory without importing a server-only module (#16266)feat: transform import aliases into relative imports in files (#16360)
Patch Changes
chore: remove dependency on sade (#16619)
chore: bump
svelte2tsxto 0.7.59 (#16745)fix: rewrite
.tsextensions inimport.meta.globpatterns whenrewriteRelativeImportExtensionsis enabled (#16776)chore: replace private fs helpers with Node built-ins (#16610)
chore: read the Svelte config via
@sveltejs/load-config(#17039)chore: remove dependency on kleur (#12548)
fix: import resolved peer dependencies as file URLs so project-relative resolution works on Windows (#16618)
fix: emit declarations when the tsconfig lives above the package root (#16568)
chore: bump
svelte2tsxto 0.7.60 (#16761)fix: declare typescript as an optional peer dependency so svelte-package works under strict node-linkers (#16073)
Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about these updates again.
This PR was generated by Mend Renovate. View the repository job log.