Repository navigation
chore(npm): update dependency eslint-plugin-unicorn to v79 - #265
renovate[bot] wants to merge 1 commit into
Conversation
[Medium risk] The P0 finding looks right: Unicorn 79 declares an ESLint >=10.4 peer while the lockfile pairs it with ESLint 9.39.5, so the lint toolchain is unsupported until ESLint is upgraded too. The P2 about the renamed abbreviation rule is also plausible. The risk rests on a 17-major jump to a dev-only lint plugin that is standalone, since a failure stays inside linting. The incidental yaml 2.8.2 to 2.9.1 bump in the lockfile does not change that. Not approved: confidence 2/5 is below the threshold of 4 Findings
SummaryUpdates eslint-plugin-unicorn from 62 to 79 and refreshes dependencies.
Review context · 6 sources · 5/5 commands · 1 overlapping pull request
Reviews (1) · Last reviewed commit: "chore(npm): update dependency eslint-plu..." · openai/gpt-6.1-sol · $0.60 |
| eslint-config-prettier: ^10.1.8 | ||
| eslint-plugin-prettier: ^5.5.4 | ||
| eslint-plugin-unicorn: ^62.0.0 | ||
| eslint-plugin-unicorn: ^79.0.0 |
There was a problem hiding this comment.
Update ESLint alongside Unicorn’s new minimum requirement · compatibility
With the root dependency installation in this PR, Unicorn 79 is paired with ESLint 9.39.5, while Unicorn has required ESLint >=10.4 since v66. The catalog still restricts ESLint to ^9.39.2 at line 82, and the lockfile explicitly binds the new plugin to that incompatible version. The shared lint task loads this plugin through eslint.config.mjs:3 and :11, so the upgrade leaves the lint toolchain outside its supported API contract rather than completing the required major-version migration.
Suggested fix
Coordinate this update with an ESLint >=10.4 migration, including the matching @eslint/js catalog entry and regenerated lockfile; otherwise retain a Unicorn version compatible with ESLint 9.
Prompt for a coding agent
In pnpm-workspace.yaml, do not upgrade eslint-plugin-unicorn to 79 while eslint remains ^9.39.2. Migrate eslint to >=10.4 and @eslint/js to the matching major, address the ESLint migration in eslint.config.mjs, and regenerate pnpm-lock.yaml so Unicorn resolves against a supported ESLint peer. If that migration is out of scope, retain a Unicorn version supporting ESLint 9.
| eslint-config-prettier: ^10.1.8 | ||
| eslint-plugin-prettier: ^5.5.4 | ||
| eslint-plugin-unicorn: ^62.0.0 | ||
| eslint-plugin-unicorn: ^79.0.0 |
There was a problem hiding this comment.
Carry the abbreviation-rule opt-out to its renamed rule · compatibility
When linting with the new recommended preset, the opt-out at eslint.config.mjs:44 no longer disables abbreviation checks. Unicorn v68 renamed prevent-abbreviations to name-replacements; in v79 the old name is a no-op compatibility rule, while the recommended preset enables name-replacements independently. This silently re-enables the naming policy the repository explicitly disables, including autofixes when running lint with --fix.
Suggested fix
Replace 'unicorn/prevent-abbreviations': 'off' with 'unicorn/name-replacements': 'off' in eslint.config.mjs.
Prompt for a coding agent
In eslint.config.mjs at line 44, replace the rule key 'unicorn/prevent-abbreviations' with 'unicorn/name-replacements', keeping its value 'off', so the existing opt-out survives the Unicorn upgrade.
Note
This PR body was truncated due to platform limits.
This PR contains the following updates:
^62.0.0→^79.0.0Warning
Some dependencies could not be looked up. Check the Dependency Dashboard for more information.
Release Notes
sindresorhus/eslint-plugin-unicorn (eslint-plugin-unicorn)
v79.0.0Compare Source
Breaking
no-top-level-side-effects: Focus on mutations of globals, and remove it from theunopinionatedpreset (#3915)24abac4checkUnknownCallsoption for stricter checking.document.title = 'x'andObject.assign(globalThis, …), are now reported, also in declarations and default exports. You may see new reports.Improvements
@type,@param, and@returnsannotations in rules that use type information (#3941)2b4bfab8bd8c0687baf82fed7eacprefer-spread,prefer-math-min-max,prefer-modern-dom-apis, andprefer-switch.175efaf3dd8fd2comment-content: Addignoreoption (#3950)3fe046econsistent-function-scoping: Ignore functions in Vitest hoisted factories (#3905)98912a9custom-error-definition: Ignore abstract TypeScript classes (#3934)ee3501fno-non-function-verb-prefix: Ignore shorthand destructuring (#3926)76e5760no-top-level-side-effects: Recognize more config helpers (#3916)d459c51no-useless-coercion: Preserve boolean return types in TypeScript (#3904)bef1571prefer-array-some: Check.find()results used as booleans (#3913)c957bf3prefer-default-parameters: Skip unsafe logical OR fallbacks (#3951)bcec97aprefer-includes: Skip incompatible TypeScript search values (#3927)d66441aprefer-includes-over-repeated-comparisons: Report negated and typed loose comparisons (#3935)6e21cb1prefer-includes-over-repeated-comparisons: Preserve TypeScript union narrowing (#3910)b5c479dprefer-literal-ascii: Preserve escaped trailing spaces in templates (#3911)360094bprefer-minimal-ternary: Skip minimizations that break types (#3892)f022d6dprefer-modern-math-apis: Use suggestions for changes that can affect numeric results (#3914)8af7c17prefer-simple-condition-first: Improvetypeofcomparisons and guards (#3948)ee3edf0prefer-simplified-conditions: Handle equivalent logical expressions (#3938)a0b2788prefer-simplified-conditions: Factor common terms in longer chains and static templates (#3942)0d8c8bcprefer-smaller-scope: Check TypeScript type aliases (#3928)290d922prefer-string-raw: Preserve TypeScript literal types in autofixes (#3912)0611546prefer-ternary: Preserve consecutive early-return guards (#3945)3fa840frequire-post-message-target-origin: Skip incompatible typed methods (#3925)387194bthrow-new-error: Ignore calls that return functions (#3894)5e35defv78.0.0Compare Source
New rules
no-unnecessary-default-arguments(#3885)1059f09no-repeated-call-wrappers(#3836)c4fd1feImprovements
recommended-somlpreset (#3870)7419b83003f0bd5e77e19prefer-default-parameters: AddcheckFallbackExpressionsoption (#3837)71bbf59prefer-ternary: AddcheckVaryingBaseandcheckComputedMemberAccessoptions (#3869)1af3c2bconsistent-boolean-name: Allowdoesprefix by default (#3853)cfad028consistent-boolean-name: Recognize promise-returning functions (#3879)769e3b8consistent-boolean-name: Fix cyclic type parameter resolution (#3821)5c4808bno-asterisk-prefix-in-documentation-comments: Remove shared indentation (#3820)a92aee1no-await-in-promise-methods: Clarify the message for nestedawait(#3867)8f73d53no-immediate-mutation: Combine a declaration with an assignment that follows it immediately (#3851)811e467no-negated-condition: Support&&and||chains of negated operands (#3834)15bfadeno-top-level-side-effects: Allow known pure imported helpers, likedefineConfig()and Reactmemo(), and check default-exported expressions (#3822)3826236no-unnecessary-parameters: Fix false positive for recursive defaults (#3844)e2d8d0fno-unnecessary-parameters: Ignore parameters named by type predicates (#3859)f0c631cno-using-resource-escape: Check TypeScript instantiation expressions (#3833)7a9f7dfprefer-at: Fix false positives for DOM collections (#3842)ca78a7aprefer-combined-guards: Combine non-literal exits in TypeScript when type information is available (#3860)2bcc7beprefer-default-parameters: Support static template literal fallbacks (#3835)3d8b40aprefer-default-parameters: Support fallbacks to earlier bindings (#3840)d4bfc1cprefer-default-parameters: Handle nullable fallback types (#3858)d75786fprefer-early-return,prefer-continue: Suggest opposite relational comparisons (#3873)de2e6daprefer-logical-operator-over-ternary: Handle non-boolean conditions (#3843)5c4d50cprefer-minimal-ternary: Ignore formatting differences in shared expressions (#3841)b0c2142prefer-minimal-ternary: Prevent unsafe TypeScript object autofixes (#3846)2f33c91prefer-observer-apis: Checkletandvarlistener functions, and ignore reassigned listeners (#3833)7a9f7dfprefer-private-class-fields: Do not autofix reassigned methods, and suggest private arrow functions for bound methods (#3823)6f0f4bbprefer-scoped-selector: Ignore queries on more non-element roots, likeownerDocumentandgetRootNode()(#3833)7a9f7dfprefer-spread: Prevent unsafe TypeScript autofixes (#3882)21e99ffprefer-ternary: Support destructuring assignments (#3852)e29d1eeprefer-ternary: Support statements that differ in only one part, likecall(test ? a : b)(#3869)1af3c2bprefer-top-level-await: Allow cached promise assignments (#3819)2fb8eb6prefer-top-level-await: Avoid false positives on non-promise calls (#3883)3f125f1relative-url-style: Support complex Markdown labels, embedded HTML in Markdown, JSX,URL.canParse(),URL.parse(), and more HTML attributes (#3854)2760ce4require-module-specifiers: Allow bareexport {}in declaration files (#3866)e727481template-indent: Ignore templates with content on the opening line (#3868)921dd8cv77.0.0Compare Source
Breaking
eslint-cssicorn(#3811)c3697c0unicorn/no-deprecated-css-features→cssicorn/no-deprecated-featuresunicorn/no-duplicate-css-selectors→cssicorn/no-duplicate-selectorsunicorn/no-duplicate-font-family-names→cssicorn/no-duplicate-font-family-namesunicorn/no-invalid-media-features→cssicorn/no-invalid-media-featuresunicorn/no-nesting-with-mixed-specificity→cssicorn/no-nesting-with-mixed-specificityunicorn/no-redundant-nested-style-rules→cssicorn/no-redundant-nested-style-rulesunicorn/no-unknown-css-annotations→cssicorn/no-unknown-annotationsunicorn/no-unknown-pseudo-selectors→cssicorn/no-unknown-pseudo-selectorsunicorn/no-unscoped-css-nesting-selector→cssicorn/no-unscoped-nesting-selectorunicorn/prefer-explicit-viewport-units→cssicorn/prefer-explicit-viewport-unitsunicorn/prefer-media-feature-range-syntax→cssicorn/prefer-media-feature-range-syntaxflat/recommendedandflat/allconfigs (#3810)6f989c6recommendedandallinstead.New rules
no-invalid-response-options(#3808)7d59006no-prevent-default-in-passive-listener(#3806)09f94f2no-invalid-boolean-attribute-value(#3807)2b91aa7no-conflicting-constraints(#3805)7c9b39ano-invalid-property-descriptor(#3804)d0bd123no-invalid-url-protocol-comparison(#3803)ec7b063no-invalid-integrity(#3802)d0b974cno-url-in-search-params(#3800)c1008cfno-invalid-dom-token(#3799)85c9aa1require-text-decoder-streaming(#3798)f3c317eno-invalid-temporal-arithmetic(#3797)47904f2no-invalid-style-set-property(#3796)239dd0bno-ineffective-csp-directives(#3795)a28a104no-invalid-intl-options(#3794)e7dc6d6no-unsafe-json-serialization(#3793)7cc147bcomma-spacing(#3790)a7a4180no-empty-link-text(#3789)742b361no-leading-empty-lines(#3786)5c509bbno-unnecessary-parameters(#3784)e143b4bprefer-promise-static-methods(#3747)f3eefdeno-javascript-url(#3746)201e128no-incomplete-accessor-override(#3745)dee7a61prefer-escaped-irregular-whitespace(#3742)d7f8222key-name-casing(#3741)a330d28prefer-literal-ascii(#3734)e9b5bcdprefer-short-escape-sequences(#3731)0e66146no-loss-of-precision(#3729)d4bdf38indent(#3726)64ff93dImprovements
recommended-css,recommended-html,recommended-json,recommended-markdown,recommended-toml, andrecommended-yaml(#3810)6f989c6a330d28consistent-compound-words,empty-brace-spaces,escape-case,name-replacements,no-manually-wrapped-comments,no-zero-fractions,number-literal-case,single-line-block-comment-style,string-contentconsistent-compound-words,empty-brace-spaces,escape-case,id-match,name-replacements,no-zero-fractions,number-literal-case,relative-url-style,single-line-block-comment-style,string-contentconsistent-compound-words,id-match,name-replacements,relative-url-stylename-replacements,relative-url-styleconsistent-compound-words,empty-brace-spaces,escape-case,name-replacements,no-manually-wrapped-comments,no-zero-fractions,number-literal-case,string-contentconsistent-compound-words,empty-brace-spaces,name-replacements,no-zero-fractionseslint-disablecomments suppress reports instead of making rules skip the code, which made the directive look unused (#3783)2428f98no-asterisk-prefix-in-documentation-comments: Support CSS and JSON, and enable inrecommendedpreset (#3725)d0f8a03number-literal-case: Move fromunopinionatedtorecommendedpreset769e2d5prefer-combined-guards: AddcheckMultiStatementBodiesoption (#3760)490ff39prefer-simplified-conditions: AddnegatedConditionsoption (#3778)2bb9171comment-content: Improve performance (#3763)cbe4b6bconsistent-conditional-object-spread: Report unnecessary boolean casts inlogicalmode (#3761)1bc3b07logical-assignment-operators: Support computed properties (#3739)1c7901fname-replacements: Preferrepositoryoverrepo(#3743)54ff97fno-await-in-promise-methods: Report nestedawait(#3758)8c2c194no-invalid-argument-count: Avoid false positives for spread arguments (#3781)769208ano-manually-wrapped-comments: Support block comments and CSS (#3744)1e82f7ano-shorthand-property-overrides: Improve shorthand detection (#3792)b1b8904no-unnecessary-array-flat-map: Remove unnecessary singleton array wrappers (#3782)eedbb2cprefer-default-parameters: Report bindings with consistent fallback expressions (#3780)1ef535dprefer-direct-iteration: Fix type inference for destructured bindings (#3809)93ef59cprefer-early-return,prefer-continue: Check guards after other statements incheckShortBodies(#3759)6f405dfprefer-logical-operator-over-ternary: Only simplify boolean branches (#3768)d84d561prefer-simple-condition-first: Handletypeofguards (#3740)118000bprefer-single-call: Make array call autofixes safe (#3770)bcb9394prefer-single-object-destructuring: Inline local sources (#3779)fa417ffprefer-uint8array-hex: Recognize more encoding patterns (#3791)dd24a9av76.0.0Compare Source
Breaking
no-immediate-mutation: AddcheckConditionalsoption and default it to off (#3707)4686e7eno-break-in-nested-loop: AddcheckContinueoption and default it to off (#3712)d8fbfdeprefer-combined-guards: AddcheckCompoundConditionsoption default it to off (#3710)Improvements
prefer-minimal-ternary: Add autofix (#3716)aaa75a4prefer-logical-operator-over-ternary: Handle boolean expressions (#3711)prefer-ternary: Preserve readable branches (#3709)f7a35aeno-typeof-undefined: Ignore TypeScript ambient variables (#3708)9245ed8db20ce1v75.0.0Compare Source
New rules
prefer-combined-guards(#3680)5d9d745no-unused-iterator-helper(#3677)8213737no-unused-builtin-method-return(#3676)b3d56a3prefer-iterator-zip(#3675)60d3b53no-useless-set-construction(#3672)639c984prefer-iterator-helpers(#3670)4c805e2prefer-json-import(#3668)1df640dprefer-temporal-conversion(#3667)74bc02eno-async-iterator-callback(#3666)bb6c245no-using-resource-escape(#3663)3424785prefer-uint8array-hex(#3661)9255132no-deprecated-css-features(#3651)e116102no-unscoped-css-nesting-selector(#3650)ebd03bdno-duplicate-css-selectors(#3646)508d9f5no-unknown-pseudo-selectors(#3644)99492cdno-invalid-media-features(#3643)ef37c1fno-unknown-css-annotations(#3642)19637eeno-nesting-with-mixed-specificity(#3640)b2f2bf9prefer-media-feature-range-syntax(#3639)19f112fno-duplicate-font-family-names(#3638)c8f81bcno-redundant-nested-style-rules(#3637)31603adImprovements
f61393a3cfa32cprefer-continue: AddcheckShortBodiesoption (#3699) [274d581](https://redirect.github.com/sindresorhus/eslint-plugin-unicorn/commit/274d58Configuration
📅 Schedule: (UTC)
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR was generated by Mend Renovate. View the repository job log.