Repository navigation
Test fixes - #2769
Open
tetlowgm wants to merge 3 commits into
Open
Test fixes#2769tetlowgm wants to merge 3 commits into
tetlowgm wants to merge 3 commits into
Conversation
Member
Author
|
@kevans91 This MR (specifically 6575c19) fixes the problem we previously saw where signing_command style signatures were broken and the tests did not notice (Breakage introduced in 88021b4 and fixed in db21207). The test was only doing an extraction of the signatures but not validating the signature. 6575c19 adds a check_loaded function to the test script that runs rquery, which requires a valid signature. I had Claude use the new fingerprint script after backing out the signing_command fix (db21207) and it correctly failed. |
The fingerprint tests only checked that pkg update extracted the signature, not that the repository was accepted, so a signature that failed to verify went unnoticed. Add a check_loaded helper that checks with rquery that the catalogue was actually loaded, and use it in every fingerprint test. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
They were skipped there because dash, the /bin/sh on Debian and Ubuntu, rejected the "read -t" in the signing script. With the script now portable they pass on Ubuntu 24.04. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
pkg_arch_to_legacy() translates the arch the same way regardless of OS, so on aarch64 Linux "pkg config altabi" reports linux:<ver>:aarch64:64. The native test only applied that translation on FreeBSD and failed on aarch64 Linux. x86_64, the only Linux arch CI covers, is not translated, which is why this went unnoticed. Compute the expected altabi after the per-OS handling instead. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Member
Author
|
Repush to accommodate changes in the tests that were brought in the ML-DSA support. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Used Claude to fixup the tests on Linux and MacOS adding a bit more test coverage.