Skip to content

docs(delete-user-data): correct empty search fields description - #3238

Open
CorieW wants to merge 1 commit into
nextfrom
docs/delete-user-data-search-fields-description
Open

CorieW wants to merge 1 commit into
nextfrom
docs/delete-user-data-search-fields-description

Conversation

@CorieW

@CorieW CorieW commented Oct 13, 2026

Copy link
Copy Markdown
Member

The AUTO_DISCOVERY_SEARCH_FIELDS description says "If left empty, document fields will not be used in auto discovery." That isn't what happens. The Extensions backend stores an empty value as unset and applies the id,uid,userId default.

  • Confirmed on corie-testing against firebase/delete-user-data@0.1.30. A validateOnly create with AUTO_DISCOVERY_SEARCH_FIELDS: "" resolves to id,uid,userId, and so does a deployed instance configured with an empty value.
  • The sentence now reads "If left empty, the default fields (id,uid,userId) are used.", as suggested in the fix(kits/delete-user-data): fall back to default search fields when empty #3231 review. Changed in extension.yaml and the generated README.md.
  • Docs only, so no version bump. The new text ships with the next release.
  • The kit change is in its own PR into kits, because next has no kits/ folder.

An empty AUTO_DISCOVERY_SEARCH_FIELDS is stored as unset by the
Extensions platform, which applies the id,uid,userId default.

@gemini-code-assist gemini-code-assist Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request updates the documentation in README.md and the parameter description in extension.yaml for the 'Auto discovery search fields' configuration. It clarifies that if the field is left empty, the default fields (id,uid,userId) are used instead of auto-discovery not being used. There are no review comments, and I have no additional feedback to provide.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants