Skip to content

Pig-latin exercise specification update - a reimplementation of whole-phrase test - #2697

Merged
IsaacG merged 1 commit into
exercism:mainfrom
Aksima:pig-latin-reimplement-test-phrase
Nov 3, 2026
Merged

IsaacG merged 1 commit into
exercism:mainfrom
Aksima:pig-latin-reimplement-test-phrase

Conversation

@Aksima

@Aksima Aksima commented Nov 2, 2026 •

Copy link
Copy Markdown
Contributor

[pig-latin] Add test case for catching an invalid assumption that all words in a phrase are of same type.

See forum discussion

Add new canonical test to verify that student's program analyses and processes each word individually, without trying to apply a single pattern to all words

@github-actions

github-actions Bot commented Nov 2, 2026

Copy link
Copy Markdown
Contributor

Hello. Thanks for opening a PR on Exercism 🙂

We ask that all changes to Exercism are discussed on our Community Forum before being opened on GitHub. To enforce this, we automatically close all PRs that are submitted. That doesn't mean your PR is rejected but that we want the initial discussion about it to happen on our forum where a wide range of key contributors across the Exercism ecosystem can weigh in.

You can use this link to copy this into a new topic on the forum. If we decide the PR is appropriate, we'll reopen it and continue with it, so please don't delete your local branch.

If you're interested in learning more about this auto-responder, please read this blog post.


Note: If this PR has been pre-approved, please link back to this PR on the forum thread and a maintainer or staff member will reopen it.

@github-actions github-actions Bot closed this Nov 2, 2026
@Cool-Katt Cool-Katt reopened this Nov 2, 2026
@IsaacG

IsaacG commented Nov 2, 2026

Copy link
Copy Markdown
Member

Please DO NOT MERGE until the description is updated per the discussion in the linked issue.

… words in a phrase are of same type.

[See forum discussion](https://forum.exercism.ord/t/add-tests-to-pig-latin-exercise/95998/)

Add new canonical test to verify that student's solution analyses and processes each word individually, without trying to apply a single pattern to all words.
@Aksima
Aksima force-pushed the pig-latin-reimplement-test-phrase branch from 0c677a8 to 72553a1 Compare November 3, 2026 09:55

@IsaacG IsaacG left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pending the commit message change

@IsaacG
IsaacG merged commit c16d0a2 into exercism:main Nov 3, 2026
10 of 11 checks passed
@keiravillekode

Copy link
Copy Markdown
Contributor

Sorry for not spotting this during the review.

The expectation needs correcting

-ywhay oday idssquay enjoyay xrayay
+ywhay oday idssquay enjoyay xraysay

@Aksima

Aksima commented Nov 4, 2026

Copy link
Copy Markdown
Contributor Author

It is me who should bring apologies.

I will prepare an update.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Incomplete tests for pig-latin exercise allows to apply one pattern to all words in phrase

6 participants