Repository navigation
Do not force gold linker for address sanitizer build - #231
Merged
Merged
Conversation
* `ADDRESS_SANITIZER` option added `-fuse-ld=gold`, which fails with `cannot find 'ld'` on systems without gold, including the current GitHub Actions runner. * Address sanitizer works with the default linker, so remove the flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
🟢 Approval recommended
There are no active review issues for the change allowing AddressSanitizer builds to use the default linker.
No open issues 🎉
What changed in this PR
Removes the gold linker requirement from AddressSanitizer builds so they can use the default linker on systems without gold, including the current GitHub Actions runner.
Changes:
- Removes
-fuse-ld=goldfrom compile and link options underADDRESS_SANITIZER. - Preserves
-fsanitize=addressfor both compilation and linking.
| File | Description |
|---|---|
| CMakeLists.txt | Uses the default linker for AddressSanitizer builds instead of forcing gold. |
Review effort: Balanced
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
ADDRESS_SANITIZERoption added-fuse-ld=gold, which fails withcannot find 'ld'on systems without gold, including the current GitHub Actions runner.Address sanitizer works with the default linker, so remove the flag.