Skip to content

Do not force gold linker for address sanitizer build - #231

Merged
greensky00 merged 1 commit into
masterfrom
junahn_pr5
Nov 13, 2026
Merged

greensky00 merged 1 commit into
masterfrom
junahn_pr5

Conversation

@greensky00

Copy link
Copy Markdown
Contributor
  • ADDRESS_SANITIZER option added -fuse-ld=gold, which fails with cannot find 'ld' on systems without gold, including the current GitHub Actions runner.

  • Address sanitizer works with the default linker, so remove the flag.

* `ADDRESS_SANITIZER` option added `-fuse-ld=gold`, which fails with
`cannot find 'ld'` on systems without gold, including the current
GitHub Actions runner.

* Address sanitizer works with the default linker, so remove the flag.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>

Copilot AI left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🟢 Approval recommended

There are no active review issues for the change allowing AddressSanitizer builds to use the default linker.

No open issues 🎉

What changed in this PR

Removes the gold linker requirement from AddressSanitizer builds so they can use the default linker on systems without gold, including the current GitHub Actions runner.

Changes:

  • Removes -fuse-ld=gold from compile and link options under ADDRESS_SANITIZER.
  • Preserves -fsanitize=address for both compilation and linking.
File Description
CMakeLists.txt Uses the default linker for AddressSanitizer builds instead of forcing gold.

Review effort: Balanced

@greensky00
greensky00 merged commit 6c3b9b9 into master Nov 13, 2026
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants