Repository navigation
Split SimpleLogger into facade and impl, reduce flush contention - #228
Merged
Merged
Conversation
* Split `SimpleLogger` into a facade (`logger.h`) holding only an `impl` pointer, and `SimpleLoggerImpl` (`logger_impl.h`) holding all the state. A library compiled with a different copy of `logger.h` no longer depends on the logger's internal layout. * Make the accessors (`getLogLevel()`, `traceAllowed()`, etc.) and `stream()`/`eos()` non-inline, as they access the state. * Add an ABI version tag to the constructor's signature, so that code compiled with an incompatible header fails to link instead of corrupting memory. * `addLogger()` no longer waits for an ongoing flush pass. New loggers go to a pending list, which the flusher merges into the registry. * Add a per-logger dirty flag, so that the background flusher skips the ring buffer scan of loggers with no new logs. * Fix lost logs under heavy logging: a writer could give up on its entry while another thread was flushing it, or when another writer took the same entry after the cursor wrapped around. The writer now retries until the write succeeds.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Split
SimpleLoggerinto a facade (logger.h) holding only animplpointer, andSimpleLoggerImpl(logger_impl.h) holding all the state. A library compiled with a different copy oflogger.hno longer depends on the logger's internal layout.Make the accessors (
getLogLevel(),traceAllowed(), etc.) andstream()/eos()non-inline, as they access the state.Add an ABI version tag to the constructor's signature, so that code compiled with an incompatible header fails to link instead of corrupting memory.
addLogger()no longer waits for an ongoing flush pass. New loggers go to a pending list, which the flusher merges into the registry.Add a per-logger dirty flag, so that the background flusher skips the ring buffer scan of loggers with no new logs.
Fix lost logs under heavy logging: a writer could give up on its entry while another thread was flushing it, or when another writer took the same entry after the cursor wrapped around. The writer now retries until the write succeeds.