Repository navigation
Search snapshot tables by level and key range - #227
Merged
Merged
Conversation
* Snapshot lookups searched every table captured by the snapshot, so a
point, nearest, or prefix lookup cost one ForestDB lookup per table.
With a few hundred tables, it was 20-45x slower than before.
* Keep the captured tables grouped by level, with level-1+ tables sorted
by min key as in the manifest, and choose the candidate tables in the
same way as `TableManifest::getTables*()`:
- Level-0: tables of the hash partition (point), or all (nearest).
- Level-1+: the table containing the key, plus the neighbor table for
nearest lookups, and all tables matching the prefix for prefix
lookups.
* Unlike the manifest, tables sharing the same min key (e.g., in the
middle of in-place compaction) are all searched, and
`prevTableSearchRequired` is captured when the snapshot is opened,
since `fixTable()` may clear it later.
* Point lookups still search all levels and choose the newest record,
as the snapshot may have been captured in the middle of compaction.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Snapshot lookups searched every table captured by the snapshot, so a point, nearest, or prefix lookup cost one ForestDB lookup per table. With a few hundred tables, it was 20-45x slower than before.
Keep the captured tables grouped by level, with level-1+ tables sorted by min key as in the manifest, and choose the candidate tables in the same way as
TableManifest::getTables*():Unlike the manifest, tables sharing the same min key (e.g., in the middle of in-place compaction) are all searched, and
prevTableSearchRequiredis captured when the snapshot is opened, sincefixTable()may clear it later.Point lookups still search all levels and choose the newest record, as the snapshot may have been captured in the middle of compaction.