Repository navigation
fix(template): escape environment variable literals - #365
Open
pcbeingused333 wants to merge 1 commit into
Open
pcbeingused333 wants to merge 1 commit into
pcbeingused333 wants to merge 1 commit into
Conversation
|
We require contributors to sign our Contributor License Agreement, and we don't have @pcbeingused333 on file. You can sign our CLA at https://e2b.dev/docs/cla . Once you've signed, post a comment here that says '@cla-bot check' |
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of #364 (item 4: env keys and values interpolated into kernel source without escaping).
Environment keys and values were interpolated directly into kernel source. Quotes and newlines could make that source invalid, and backslashes could silently change values. Cleanup used the same interpolation when restoring global values or deleting execution-specific keys.
Use Python repr, JSON string literals for JavaScript/TypeScript and Java, quoted strings with named arguments supplied through do.call for R, and shell quoting for Bash assignments and deletion. This keeps the existing environment lifecycle while preserving literal keys and values.
Add parameterized kernel regressions for quotes, newlines, backslashes, and cleanup. Local dependency-free checks of the production methods passed under Python, Node, and Bash, including global-value restoration and shell metacharacters. The E2B integration suite and R/Java runtimes were not available locally.
This addresses escaping only. History retention, logging, and cancellation cleanup from #364 remain outside this change, so the issue should remain open.
AI disclosure: This change and its tests were generated with assistance from OpenAI Codex.