Skip to content

Fix helperildll build race in Crossgen2 determinism test - #135878

Merged
agocke merged 2 commits into
mainfrom
copilot/build-race-condition-fix
Oct 15, 2026
Merged

agocke merged 2 commits into
mainfrom
copilot/build-race-condition-fix

Conversation

Copilot AI commented Oct 15, 2026 •

Copy link
Copy Markdown
Contributor

The determinism test rebuilt crossgen2smoke with a global OutputPath override, creating separate MSBuild instances that shared intermediate files. Concurrent writes to helperildll.dll could leave consumers reading incomplete metadata.

  • Share the build: Replace the custom MSBuild invocation with a standard ProjectReference.
  • Preserve the layout: Copy the three required DLLs into the determinism test’s existing input directory after building, without copying the smoke-test wrapper.

@azure-pipelines

azure-pipelines Bot commented Oct 15, 2026 •

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).
13 pipeline(s) were filtered out due to trigger conditions.
There may be pipelines that require an authorized user to comment /azp run to run.

@dotnet-policy-service

Copy link
Copy Markdown
Contributor

Tagging subscribers to this area: @dotnet/runtime-infrastructure
See info in area-owners.md if you want to be subscribed.

Co-authored-by: agocke <515774+agocke@users.noreply.github.com>
Copilot AI changed the title [WIP] Fix build race condition for helperildll.dll Fix helperildll build race in Crossgen2 determinism test Oct 15, 2026
Copilot AI requested a review from agocke October 15, 2026 19:04
@agocke
agocke marked this pull request as ready for review October 15, 2026 20:14
@agocke
agocke enabled auto-merge (squash) October 15, 2026 20:16
@agocke
agocke requested a review from jtschuster October 15, 2026 20:16
@agocke
agocke merged commit 2dd0ae7 into main Oct 15, 2026
79 of 82 checks passed
@agocke
agocke deleted the copilot/build-race-condition-fix branch October 15, 2026 22:21
@github-project-automation github-project-automation Bot moved this to Done in AppModel Oct 15, 2026
@dotnet-milestone-bot dotnet-milestone-bot Bot added this to the 12.0-preview1 milestone Oct 19, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

Status: Done
Status: Done

Development

Successfully merging this pull request may close these issues.

Build race condition while building helperildll.dll

4 participants