Skip to content

Validate --maxWidth instead of throwing #3309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
timcassell merged 1 commit into from
Oct 29, 2026
Merged

Validate --maxWidth instead of throwing #3309

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 6 additions & 0 deletions src/BenchmarkDotNet/ConsoleArguments/ConfigParser.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -392,6 +392,12 @@ private static bool Validate(CommandLineOptions options, ILogger logger)
}
}

if (options.MaxParameterColumnWidth < SummaryStyle.DefaultMaxParameterColumnWidth)
{
logger.WriteLineError($"The provided --maxWidth {options.MaxParameterColumnWidth} is invalid. The minimum is {SummaryStyle.DefaultMaxParameterColumnWidth}.");
return false;
}

if (options.EnvironmentVariables.Any(envVar => envVar.IndexOf(EnvVarKeyValueSeparator) <= 0))
{
logger.WriteLineError($"Environment variable value must be separated from the key using '{EnvVarKeyValueSeparator}'. Use --help to see examples.");
Expand Down
15 changes: 15 additions & 0 deletions tests/BenchmarkDotNet.Tests/ConfigParserTests.cs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1005,6 +1005,21 @@ public void UserCanSpecifyCustomMaxParameterColumnWidth()
Assert.Equal(customValue, parsedConfig.SummaryStyle.MaxParameterColumnWidth);
}

[Theory]
[InlineData("19")]
[InlineData("0")]
[InlineData("-1")]
public void MaxParameterColumnWidthBelowMinimumFailsValidation(string maxWidth)
{
var logger = new AccumulationLogger();

var (isSuccess, config, _) = ConfigParser.Parse(["--maxWidth", maxWidth], logger);

Assert.False(isSuccess);
Assert.Null(config);
Assert.Contains("--maxWidth", logger.GetLog());
}

[Fact]
public void UserCanSpecifyEnvironmentVariables()
{
Expand Down
Loading