Repository navigation
send: use a fresh sender key for every broadcast list message - #1
Closed
ADAMAYAMEOGO wants to merge 2 commits into
Closed
ADAMAYAMEOGO wants to merge 2 commits into
ADAMAYAMEOGO wants to merge 2 commits into
Conversation
This was referenced Sep 29, 2026
A phone only records a message that another of its devices sent to one of its broadcast lists when it receives it as a DeviceSentMessage. It gets one when it can't decrypt the fan-out copy and asks for a retry. Once it holds the list's sender key (e.g. after answering such a retry), it decrypts the fan-out copy directly and never shows the message as sent: neither in the list nor in the recipients' chats. Recipients are not affected. Resetting the sender key before each message to a (non-status) broadcast list keeps the account's own devices on the retry path, so every message shows up on the phone like one sent from it. Recipients receive the new key with each message anyway. Statuses and groups are unchanged. Tested with WAHA/GOWS on a personal and a WhatsApp Business account, with consecutive messages to a phone-created list.
ADAMAYAMEOGO
force-pushed
the
fix/broadcast-list-rotation
branch
3 times, most recently
from
October 3, 2026 13:54
a57f2b0 to
749abd7
Compare
Author
|
Replaced by #2, the same change on |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Needed to send to phone-created broadcast lists from GOWS (devlikeapro/waha#468).
When a linked device sends to one of the account's broadcast lists, the phone only records the message (in the list and in each recipient's chat) when it gets it as a DeviceSentMessage. That happens through the retry path, when it can't decrypt the fan-out copy. Once the phone holds the list's sender key, it decrypts the fan-out copy directly, and the message never shows up on the phone. Recipients are not affected.
This resets the sender key before each message to a non-status broadcast list. Statuses and groups are unchanged. Recipients get the new key with each message anyway.
Tested with consecutive messages to a phone-created list, on a personal and a WhatsApp Business account. Without the change, only the first message after a key change shows up on the phone. GOWS will need its whatsmeow
replacebumped to include this.