Repository navigation
Conversation
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What this fixes
Fixes #3391. The Desktop apps overview links
Deno.BrowserWindow(twice) andDeno.autoUpdate()to API-reference URLs that return 404:https://docs.deno.com/api/deno/~/Deno.BrowserWindow→ 404https://docs.deno.com/api/deno/~/Deno.autoUpdate→ 404Root cause
The
/apireference is generated fromdeno docand currently has no entries for these desktop symbols, so the/api/deno/~/...links are dead. The desktop guides that document both symbols already exist and are the correct targets.Fix
Point the three links at the sections that document them:
/runtime/desktop/windows/#creating-windowsDeno.BrowserWindowlifecycle →/runtime/desktop/windows/#lifecycleDeno.autoUpdate()→/runtime/desktop/auto_update/Bumped
last_modifiedperAGENTS.md. No prose changes.Verification
deno fmt --check→ Checked 885 files, passdeno task test→ok | 17 passed (1118 steps) | 0 failed, passdeno task check:freshness→ passdeno task build:light→ 1109 files generated, passcurl -o /dev/null -w '%{http_code}' https://docs.deno.com/api/deno/~/Deno.BrowserWindow→404(same forDeno.autoUpdate)/runtime/desktop/windows/→200,/runtime/desktop/auto_update/→200; the built page emits the three new hrefs and both anchors (#creating-windows,#lifecycle) exist in the built pagesdeno lint→ 172 pre-existing TS/JS findings; this diff is Markdown-only, so none are introduced hereRisk / rollback
Three link targets in one page. Reverting restores the previous links.
AI assistance: prepared with an AI coding agent; I reviewed and ran the checks above.