Repository navigation
ci: 243 unit testing added to cicd pipeline - #246
Merged
Merged
Conversation
frayle-ons
marked this pull request as ready for review
October 16, 2026 18:07
Contributor
Author
|
I've updated the PR to use the latest version of unit tests in main. The CI now invokes the make file, which provides a standardised way to run all unit tests. Finally, I've split the See below a screenshot of the running ci process on push to this PR, we can see the unit tests running separately: 
|
lukeroantreeONS
approved these changes
Oct 27, 2026
lukeroantreeONS
left a comment
lukeroantreeONS
left a comment
Contributor
There was a problem hiding this comment.
Happy to approve
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
✨ Summary
These changes add unit test testing into the CI GitHub actions workflow.
Specifically, the unit test checks now run as an additional job under the CI workflow, distinct from lint-test, and is conditioned to run only when a PR's status is set as 'ready for review' (and all all subsequent updates to the ready for review PR).
The unit tests are run using the
Makefilecommandmake run-tests-allfor consistency.📜 Changes Introduced
✅ Checklist
Changes pass all configured pre-commit steps
🔍 How to Test
Start by checking out the branch that corresponds to this PR. Then create your own PR, saving it as draft and viewing the CI jobs that run. It should show that
lint-testis skipped. Following this, convert the test PR to ready for review and observe that the skipped job does run. Inspecting the drop down, see that the unit tests do indeed run as part of the CI step.