Skip to content

Keep state for a bound resource whose update fails under DMS - #7061

Draft
shreyas-goenka wants to merge 1 commit into
isaac/dmsbind-3-dmsfrom
isaac/dmsbind-4-failure
Draft

shreyas-goenka wants to merge 1 commit into
isaac/dmsbind-3-dmsfrom
isaac/dmsbind-4-failure

Conversation

@shreyas-goenka

Copy link
Copy Markdown
Contributor

If a bind-and-update's update call fails, record the resource's remote state instead of nothing. DMS rejects a failed BIND_AND_UPDATE without state, which left the job unrecorded and made the next deploy create a duplicate; the extended record-op-fault test covers this.

This pull request and its description were written by Isaac.

When a BindAndUpdate's update call fails before any state is saved, record the
resource's remote state instead. The service rejects a failed BIND_AND_UPDATE
operation without state (it acts on a resource that exists), which left the job
unrecorded and made the next deploy create a duplicate. With the baseline
recorded, the next deploy updates the bound job as expected.

Co-authored-by: Isaac <no-reply@databricks.com>
@shreyas-goenka
shreyas-goenka added this pull request to stack #7062 October 14, 2026 15:03
@eng-dev-ecosystem-bot

Copy link
Copy Markdown
Collaborator

Integration test report

Commit: 7b91e70

Run: 38586179693

Env 🔄​flaky ✅​pass 🙈​skip Time
✅​ aws linux-2core-8gb 278 17 10:32
🔄​ aws-windows-latest-4core-16gb 1 279 15 7:15
🔄​ azure linux-2core-8gb 1 276 17 10:40
✅​ azure-windows-latest-4core-16gb 279 15 6:55
✅​ gcp linux-2core-8gb 278 17 9:31
✅​ gcp-windows-latest-4core-16gb 280 15 7:53
Test Name aws-windows-latest-4core-16gb azure linux-2core-8gb
🔄​ TestSyncFullFileSync ✅​p 🔄​f
🔄​ TestSyncIncrementalFileOverwritesFolder 🔄​f ✅​p
Top 8 slowest tests (at least 2 minutes):
duration env testname
3:20 aws-windows-latest-4core-16gb TestAccept
3:17 gcp-windows-latest-4core-16gb TestAccept
3:09 azure-windows-latest-4core-16gb TestAccept
3:01 azure linux-2core-8gb TestFilerWorkspaceFilesExtensionsStat
2:44 gcp-windows-latest-4core-16gb TestImportDirWithOverwriteFlag
2:08 aws-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files_extensions
2:05 azure-windows-latest-4core-16gb TestAccept/bundle/dms/bind/DMS=true
2:00 gcp-windows-latest-4core-16gb TestFilerRecursiveDelete/workspace_files

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants