Repository navigation
Force bulk upload temp files onto S3 when env still says local - #3676
Merged
Merged
Conversation
Deployed apps ignore BULK_UPLOAD_TEMP_DISK=local so validate/import share the same object across web nodes; verify the put before continuing. Co-authored-by: Cursor <cursoragent@cursor.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
BULK_UPLOAD_TEMP_DISK=local, which kept writing to per-node disk → Import: "Uploaded file no longer available".local/testing, always use the cloud disk (s3) even if env/cache sayslocal.Storage::put(private), fail fast if the object is missing right after upload.Test plan
BULK_UPLOAD_TEMP_DISK=s3andconfig:clear(code no longer requires this, but keeps config honest)(disk: s3)or(disk: local)Made with Cursor