Skip to content

Force bulk upload temp files onto S3 when env still says local - #3676

Merged
bernardhanna merged 1 commit into
masterfrom
fix/bulk-upload-force-s3
Oct 9, 2026
Merged

bernardhanna merged 1 commit into
masterfrom
fix/bulk-upload-force-s3

Conversation

@bernardhanna

Copy link
Copy Markdown
Collaborator

Summary

  • Fix bulk upload: store temp files on S3 #3675 defaulted to S3, but Forge often still has BULK_UPLOAD_TEMP_DISK=local, which kept writing to per-node disk → Import: "Uploaded file no longer available".
  • Outside local/testing, always use the cloud disk (s3) even if env/cache says local.
  • Store via Storage::put (private), fail fast if the object is missing right after upload.
  • Error message now includes the disk name for easier diagnosis.

Test plan

  • Deploy, then upload a fresh file (old sessions still on local will not work)
  • Preview → Import should succeed
  • Optional: set Forge BULK_UPLOAD_TEMP_DISK=s3 and config:clear (code no longer requires this, but keeps config honest)
  • If it still fails, note whether the error says (disk: s3) or (disk: local)

Made with Cursor

Deployed apps ignore BULK_UPLOAD_TEMP_DISK=local so validate/import share the same object across web nodes; verify the put before continuing.

Co-authored-by: Cursor <cursoragent@cursor.com>
@bernardhanna
bernardhanna merged commit 9ff980d into master Oct 9, 2026
1 check failed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant