Repository navigation
fix: add missing break in playerCinemaModeButton case in core.js - #4417
Merged
Merged
Conversation
hkzo
force-pushed
the
fix/expected-break-before-case
branch
from
October 24, 2026 23:04
c560f05 to
3e2988b
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The
case 'playerCinemaModeButton'incore.jswas missing abreakstatement. This caused an accidental fall-through to the subsequentcase 'playerRepeatButton', which, while currently guarded by anifcondition, poses a risk for future maintenance and potential bugs.Changes
break;statement tocase 'playerCinemaModeButton'injs&css/web-accessible/core.js.Why
In the current implementation, the fall-through does not cause immediate functional issues because the next case (
playerRepeatButton) is guarded by anifstatement. However, leaving missingbreakstatements makes it difficult for maintainers to distinguish between "intentional fall-through" (used as a technique) and "accidental fall-through" (a bug). This increases the risk of regression if future logic changes are made to the subsequent cases without adding appropriate guards.Testing
breakstatement is correctly placed.git diff --checkpassed.Notes
I used AI assistance to help draft/translate this description.