[imparable2022]

Summary

Improve keyboard and screen-reader semantics in the ImprovedTube settings UI without changing existing settings behavior or storage.

This adds an accessibility compatibility layer for the Satus-rendered menu and loads it from the popup and side-panel UI.

What changes

• expose custom switches with role="switch", keyboard activation and aria-checked
• give native selects, checkboxes, radios, sliders and text/time controls accessible names from their Satus skeleton labels
• expose shortcut/color-picker controls as keyboard-operable buttons
• label icon-only buttons and hide decorative SVGs from the accessibility tree
• expose titled sections as labelled regions with headings
• add accessible iframe titles
• add visible focus indicators for keyboard navigation
• dynamically enhance newly inserted controls with MutationObserver

Scope

This PR intentionally does not change layer-entry focus, dialog behavior, YouTube-page injected controls, locale selection, translations, or feature behavior. Those are split into follow-up PRs so each decision can be reviewed independently.

Validation

The complete accessibility series was manually tested in Chromium with NVDA using the unpacked extension. Existing Satus rendering and storage keys are preserved.

[wahajahmed010]

Strong scope discipline (no behavior changes, accessibility is additive) and the scope-of-future-PRs callout is helpful for reviewers. Two notes on the implementation:

1. Auto-install side effect on import. The IIFE at the top of menu/accessibility.js calls api.install() whenever the module loads in a non-CommonJS environment with a global document:

if (root && root.document && typeof module === 'undefined') api.install();

That means any test, dev snippet, or future popup that imports this file for any reason — even just to inspect ImprovedTubeMenuAccessibility — will start a MutationObserver and start mutating the DOM. The recommended pattern is to export install/uninstall and only run install from the explicit load sites (popup, side-panel). Tests can still call install directly via the global. The current shape makes the module un-importable for inspection, which is a real cost.

2. MutationObserver lifetime is unclear from the visible diff. The PR description says "dynamically enhance newly inserted controls with MutationObserver" but I do not see a matching observer.disconnect() in the visible portion. If the observer lives for the lifetime of the popup/side-panel page, that's fine, but the install/uninstall pair should keep them paired so a re-install (e.g. after a settings update) doesn't accumulate observers and double-apply aria-* attributes. The same install/uninstall separation above also fixes this.

The semantic-enhancement functions themselves are solid — accessibleName/setLabel precedence is reasonable, role="switch" plus aria-checked is the correct pattern, and the icon-name fallback via extension.skeleton is a thoughtful way to label existing Satus buttons without re-rendering them.

[ImprovedTube2]

thank you so much! @imparable2022 @wahajahmed010

why add lang="en" ?

[imparable2022]

I addressed the review points: installation is now explicit at the popup and side-panel load sites, uninstall() disconnects the MutationObserver, and lang="en" has been removed. Menu language resolution will be handled dynamically in #4335.