Repository navigation
Conversation
lxcxjxhx
force-pushed
the
fix/header-size-limit
branch
from
November 7, 2026 13:36
ddab209 to
1db5931
Compare
Author
|
Rebased onto the current The red checks on the previous head were both This PR touches Not run locally: this host has no Go toolchain, so the evidence is the rebased diff plus the added |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Add a
MaxHeaderSizefield toHeaderScanner. When set to a positive value, the scanner stops parsing and returnserrHeaderTooLongonce the cumulative header bytes exceed the limit. The default is 0 (no limit), so existing callers are unaffected.Why
Malicious or buggy clients can send an arbitrarily large header block and cause the parser to loop until OOM. Having a built-in size guard lets callers defend against this without wrapping the scanner externally.
Changes
headerscanner.go: addMaxHeaderSize intfield and a size check at the top ofNext()headerscanner_test.go: addTestHeaderScannerMaxHeaderSizeandTestHeaderScannerMaxHeaderSizeDisabledTesting
All existing tests pass. New tests cover:
errHeaderTooLongCloses #1497