Repository navigation
Conversation
cansuaa
changed the title
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4953 +/- ##
=======================================
Coverage 97.72% 97.72%
=======================================
Files 995 995
Lines 32129 32131 +2
Branches 11850 11852 +2
=======================================
+ Hits 31399 31401 +2
+ Misses 723 684 -39
- Partials 7 46 +39 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
| spaceTableCellVertical: '2px', | ||
| spaceExpandToggleFocusOutlineGutter: '1px', | ||
| spaceButtonInlineLinkFocusOutlineGutter: '1px', |
There was a problem hiding this comment.
spaceTableHeaderFocusOutlineGutter is not included here because it isn't needed in the compact table case since there is still plenty of space between the header and table header columns and it also makes focus highlight not show up at all when set to 0px
|
|
||
| export type ColorPaletteDictionary = Partial<TokenCategory<ColorPaletteTokenName, GlobalEntry>>; | ||
| export type TypographyDictionary = Partial<TokenCategory<TypographyTokenName, GlobalEntry>>; | ||
| export type DensityTypographyDictionary = Partial<TokenCategory<TypographyTokenName, DensityModeEntry>>; |
There was a problem hiding this comment.
Created a new one, because typography should become part of density only in one-theme and core but not classic and visual refresh
| "start:react18": "npm-run-all --parallel start:watch start:react18:dev", | ||
| "start:react18:dev": "cross-env NODE_ENV=development REACT_VERSION=18 webpack serve --config pages/webpack.config.cjs", | ||
| "postinstall": "prepare-package-lock", | ||
| "postinstall": "node ./scripts/install-peer-dependency.js theming-core:dev-v3-cansua", |
There was a problem hiding this comment.
This command and the script is added so that this PR uses dev-v3-cansua branch in theming-core package because the changes there are needed in order to be able to run actions cloudscape-design/theming-core#216
I don't think the script needs to be committed, once the theming-core PR is merged, the command and script can be reverted
c9e8374 to
79cfd9f
Compare
This reverts commit ae6cdfb.
# Conflicts: # src/button/styles.scss
| #{$cell-vertical-padding} + (#{awsui.$border-item-width} - #{awsui.$border-divider-list-width}) | ||
| ); | ||
| $cell-horizontal-padding: awsui.$space-scaled-l; | ||
| $cell-horizontal-padding: calc(#{awsui.$space-s} + #{awsui.$space-scaled-xs}); |
There was a problem hiding this comment.
updated to match how header cell padding is implemented (2 separate paddings on separate elements)
This branch was successfully deployed
2 participants
Description
Update One Theme compact mode values to be more compact. A collaboration between console squad and visual design :)
Related links, issue #, if available: n/a
How has this been tested?
Review checklist
The following items are to be evaluated by the author(s) and the reviewer(s).
Correctness
CONTRIBUTING.md.CONTRIBUTING.md.Security
checkSafeUrlfunction.Testing
By submitting this pull request, I confirm that you can use, modify, copy, and redistribute this contribution, under the terms of your choice.