Skip to content

Assert the debug output's value, not its colour #21

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cjbarth merged 1 commit into from
Sep 17, 2026
Merged

Assert the debug output's value, not its colour #21

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions test/Gren.membership.spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,6 +3,7 @@ import fs from "node:fs";
import os from "node:os";
import path from "node:path";
import { execFileSync } from "node:child_process";
import { stripVTControlCharacters } from "node:util";
import Gren from "../lib/src/Gren.js";
import * as git from "../lib/src/_git.js";
import { createReleaseRepo } from "./fixtures/release-repo.js";
Expand Down Expand Up @@ -815,10 +816,13 @@ describe("Gren release membership", () => {
process.stdout.write = write;
}

const output = written.join("");
// chalk colours the option names only when stdout is a terminal, so the run that
// matters -- a maintainer's, by hand -- is the one an assertion on the escape codes
// would fail. Assert the value, not the spelling it arrived in.
const output = stripVTControlCharacters(written.join(""));

assert.notInclude(output, "ghp_averysecrettoken", "The token is not in the output");
assert.include(output, "Token:", "The option is still reported");
assert.include(output, "Token: <hidden>", "The option is still reported");
assert.include(output, "Repo: current", "The other options are still reported");
});

Expand Down
Loading