Repository navigation
chore(gates): rebuild agent-device.dev after each stable release - #4036
Conversation
/.well-known/mcp.json takes the npm latest version when the site builds, but a stable release is a tag push, which builds nothing on Vercel, so the manifest stayed a version behind until the next site change on main. A redeploy-site job now calls the site's Vercel deploy hook (secret VERCEL_SITE_DEPLOY_HOOK) after publish. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Size Report
Startup median (7 runs, lower is better):
|
There was a problem hiding this comment.
All reported issues were addressed across 2 files
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
|
The code needs one change at 07a27b9: the release-workflow guard now fails on this head. test/ci/release-workflow.test.ts:30 runs Coverage is likely red for this reason, because it runs the full vitest suite including that file. Its log is cut off before the test summary, so I confirmed the match by running the regex, not from CI. Smoke Tests fails on an Android emulator snapshot assertion (expected an added line containing "Open automation lab") on a route this diff does not touch, so it looks unrelated. I did not run the unit test locally, call the deploy hook, or fetch agent-device.dev, and the manual-trigger and 0.21.33 claims rest on the PR body only. The new job first runs on the next stable release, and I cannot check from here that the secret exists. The open inline thread on the Not blocking, take or leave: the job posts the hook right after Before merge, Coverage must pass with the scoped test, and there are no conflicts. |
- test/ci/release-workflow.test.ts rejected any `secrets.` in release.yml, so the deploy hook failed it. The token check still covers the whole file; the secret check now covers the jobs that build and publish packages, which read none, and names redeploy-site's deploy hook as the workflow's only secret. - redeploy-site waits (up to 5 minutes) until npm serves the release as latest before it calls the hook, so the site never builds the previous version; a comment names what VERCEL_SITE_DEPLOY_HOOK holds. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
There was a problem hiding this comment.
All reported issues were addressed across 2 files (changes from recent commits).
Reply with feedback, questions, or to request a fix.
View guided diff | Turn on auto-fix | Re-trigger cubic
When two stable releases run close together, the newer one moves latest past the older run's version, and the exact match timed out although the site only needs the current release. The wait now accepts a latest at or past the planned version (sort -V). Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The code looks good at 91131f6. The scoped secrets guard in test/ci/release-workflow.test.ts and the Not blocking, and fine to take or leave: the Both earlier Cubic threads, already resolved, are fixed at this head: the secrets scope test and the I read the diff and relied on CI for the tests. I did not run them locally, call the deploy hook, fetch agent-device.dev, or check that the repository secret exists. The job has not run on a real stable release, so the next tag is its first live run. |
Summary
agent-device.dev builds
/.well-known/mcp.jsonwith the npmlatestversion read at build time. A stable release is a tag push, which builds nothing on Vercel, so the manifest stayed one version behind until the next site change on main.A
redeploy-sitejob inrelease.ymlwaits until npm serves this release or a newer one aslatest, then calls the site's Vercel deploy hook, for stable releases only. The hook ("release", production build of main) and the repository secretVERCEL_SITE_DEPLOY_HOOKalready exist. Themcp.jsonroute's comment now says how the version follows releases.3 files:
release.yml, its OIDC guard (test/ci/release-workflow.test.ts: thesecrets.check now covers the build and publish jobs, and names the deploy hook as the only secret in the workflow), and themcp.jsonroute comment.Validation
At 91131f6,
pnpm check:affected --run --head HEADpassed every runnable check (fail-open full set), andtest/ci/release-workflow.test.ts(3/3),scripts/gate/workflows.test.ts(15/15), the release-plan and release-version tests and lint pass. At 07a27b9 the guard failed because it matched anysecrets.(the earlier "15/15" was the gate workflow tests, not this guard). The hook was triggered once by hand: Vercel built a production deployment of main labelled "release" (READY), and agent-device.dev then servedmcp.jsonwith 0.21.33, the current npmlatest. The job itself first runs on the next stable release.🤖 Generated with Claude Code