Repository navigation
fix(help): say --launch-console is for local iOS simulator launches - #4028
Merged
Merged
Conversation
The debugging workflow help still said direct iOS simulator app launches, while open's flag help and the docs say local since #3938, where a provider-owned simulator refuses the flag. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub. 1 Skipped Deployment
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
The change at 47c3569 looks good: it only updates the |
thymikee
added
the
ready-for-human
Contributor
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to the #3938 review. The debugging workflow help (
src/commands/schema/cli-help-workflows.ts) still said--launch-consoleis "only for direct iOS simulator app launches". Since #3938 a provider-owned iOS simulator refuses the flag, andopen's flag help and the docs say "local". The workflow help now says "local iOS simulator" too, and the two tests that pin the wording are updated. Scope expansion: none.Behavior note from the same review, accepted rather than changed: on a provider-owned device the launch-console refusal runs before the request-shape checks, so
open --launch-console <path>with no app target, or with a URL, returnsUNSUPPORTED_OPERATION(launch-console-owner-unadmitted) instead ofINVALID_ARGS. Both answers refuse before the device is touched, and the owner refusal is the actionable one there: the flag cannot work on that device whatever the arguments are.Validation
pnpm check:affected --runat47c3569e7b: format, lint, typecheck, layering, fallow, build, and vitest-related passed (exactCommit=true).🤖 Generated with Claude Code