Repository navigation
docs(mutation): state the file-name rule that marks test support code - #4011
Merged
Merged
Conversation
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
![cubic-dev-ai[bot]](https://avatars.githubusercontent.com/in/1082092?s=60&v=4){kind=small}
Contributor
Size Report
Startup median (7 runs, lower is better):
|
Member
Author
|
The change looks good at 58056ff. The change only edits a comment in |
thymikee
added
the
ready-for-human
Contributor
|
thymikee
added a commit
that referenced
this pull request
Oct 28, 2026
* origin/main: (76 commits) fix(open): refuse --launch-console on a provider-owned device before the relaunch close (#3938) fix(test-app): keep the inert surface control above the settings fold (#3993) fix(fill): redact the read-back of a sensitive fill (#4014) fix(apple): read the runner cache toolchain key from Xcode's own files (#3995) docs: point stable test suites to e2e (#4010) docs(mutation): state the file-name rule that marks test support code (#4011) refactor(kernel): read the Action Button leaf from isHandheldAppleDevice (#3988) fix(ios): match alert labels through the OS prompt strings of the preferred languages (#4006) fix(mutation): measure each kernel against the tests that import it (#3994) fix(webdriver): avoid unused pre-tap focus geometry reads (#3997) refactor(apple): share coordinate drag execution (#4003) fix(apple): type a text-entry-trait element as a text input in the simulator AX tree (#4008) refactor(contracts): own the unsupported-interactor stub both platforms duplicated (#4002) refactor: reuse canonical device identity projections (#3996) refactor(apple): share simulator status-bar diagnostics (#3998) refactor(runtime): share host command runner construction (#3999) refactor(android): centralize session error encoding (#4000) chore: mark 0.21.33 as released chore(gates): detect new native duplication with jscpd (#3980) fix(android): publish the Compose role on its clickable parent instead of a fake child (#3983) ...
thymikee
added a commit
to janjankowski-cs/agent-device
that referenced
this pull request
Oct 28, 2026
* base-3865: (76 commits) fix(open): refuse --launch-console on a provider-owned device before the relaunch close (callstack#3938) fix(test-app): keep the inert surface control above the settings fold (callstack#3993) fix(fill): redact the read-back of a sensitive fill (callstack#4014) fix(apple): read the runner cache toolchain key from Xcode's own files (callstack#3995) docs: point stable test suites to e2e (callstack#4010) docs(mutation): state the file-name rule that marks test support code (callstack#4011) refactor(kernel): read the Action Button leaf from isHandheldAppleDevice (callstack#3988) fix(ios): match alert labels through the OS prompt strings of the preferred languages (callstack#4006) fix(mutation): measure each kernel against the tests that import it (callstack#3994) fix(webdriver): avoid unused pre-tap focus geometry reads (callstack#3997) refactor(apple): share coordinate drag execution (callstack#4003) fix(apple): type a text-entry-trait element as a text input in the simulator AX tree (callstack#4008) refactor(contracts): own the unsupported-interactor stub both platforms duplicated (callstack#4002) refactor: reuse canonical device identity projections (callstack#3996) refactor(apple): share simulator status-bar diagnostics (callstack#3998) refactor(runtime): share host command runner construction (callstack#3999) refactor(android): centralize session error encoding (callstack#4000) chore: mark 0.21.33 as released chore(gates): detect new native duplication with jscpd (callstack#3980) fix(android): publish the Compose role on its clickable parent instead of a fake child (callstack#3983) ...
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Follow-up to #3994 review (comment). The
isTestSupportModulecomment said shared packages stay opaque. The rule reads only the file name, so a*-fixturessubpath that a workspace package exports is looked through as well.@agent-device/test-kitstays opaque only because tests reach it through its barrel. The comment now states that rule. Comment only; no behavior change.Validation
pnpm check:affected --run --head 58056ff752: passed,exactCommit=true.🤖 Generated with Claude Code