Repository navigation
Add conversation-based Loop Runtime autoscaling on GKE - #122
Conversation
Codex Review SummaryThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: 85d7501ff5
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "Codex (@codex) review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "Codex (@codex) address that feedback".
| - it: should restore explicit fixed replicas when autoscaling is disabled | ||
| values: *values | ||
| set: | ||
| loopRuntime.replicas: 3 | ||
| loopRuntime.autoscaling: null |
There was a problem hiding this comment.
Cover the required autoscaling upgrade and empty-value matrix
The new suite does not exercise the helper's reuse-values/defaulting branches: every enabled case inherits the complete autoscaling defaults, and the null case disables the entire map rather than testing null settings while enabled. There are also no cases for reversed or fractional replica bounds, despite the commit explicitly promising to reject them. Add cases that remove the retained autoscaling map before applying partial overrides, supply null individual settings, and exercise the distinct invalid-bound branches. These are explicitly required release-blocking checks under AGENTS.md, not optional coverage improvements.
AGENTS.md reference: AGENTS.md:L14-L17
Useful? React with 👍 / 👎.
0abd7c4 to
9ca0b85
Compare
Builds on #120 with opt-in conversation-based Loop Runtime autoscaling through GKE custom metrics, defaulting to 1–50 pods at 50% claimed capacity.
Applications expose
loop_runtime_claimed_conversation_utilization(0–100) on their runtime HTTP metrics endpoint; missing application support leaves the HPA unable to perform metric-driven scaling, with no image-version gate.Helm leaves replica ownership to the HPA while enabled, applies a five-minute downscale window, and restores fixed replicas when disabled.
Sandbox-worker replicas remain separately configured and must provide enough capacity for the runtime limit.
v, full/short/numeric SHAs, prerelease and custom tags