Repository navigation
Conversation
jwils
requested review from
BrianSigafoos-SQ,
bsorbo,
ellisandrews-toast,
jwondrusch,
marcdaniels-toast,
myronmarston and
rossroberts-toast
as code owners
November 2, 2026 00:08
This was referenced Nov 2, 2026
jwils
marked this pull request as draft
November 2, 2026 00:56
jwils
force-pushed
the
joshuaw/proto-ingestion-adapter
branch
from
November 4, 2026 23:50
1cc170f to
9ec7bb3
Compare
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Why
The indexer has a format-neutral
IngestionAdapterseam and sharedfor_each_ingestion_formattest suite (#1412), but the:protoformat is still pending becauseelasticgraph-proto_ingestiondoes not yet validate native protobuf records or register a"proto"ingestion adapter.What
Add
ProtoIngestion::RecordValidatorandProtoIngestion::IngestionAdapter, wireProtoIngestion::IndexerExtensionto register"proto", and enable:protoacross the shared indexer test suite.How
ProtoIngestion::RecordValidatorvalidates ElasticGraph constraints that protobuf wire decoding cannot express: unknown enum integer values,JsonSafeLongrange, finiteFloatvalues, calendarDatestrings,DateTimeTimestampbounds,LocalTime,TimeZone, andUntypedJSON payloads. Retained wire-contract checks (JsonSafeLongand enum membership) stay unsampled whenskip_record_validation: true.ProtoIngestion::IngestionAdaptervalidates incomingEvent[Google::Protobuf::Message]records, unwraps top-level union/interface messages to their concrete subtype, verifies required rollover timestamps, and pairs events withProtoIngestion::RecordPreparerwithout JSON schema version checks.Risk
Activates
"proto"ingestion when protobuf runtime metadata is present in the schema artifacts. Existing JSON ingestion paths are unchanged.Testing
No manual testing.
Bigger picture
Completes the 3-PR protobuf indexing parity stack (#1441, #1442, #1450), running the shared
elasticgraph-indexerunit, integration, and acceptance specs against both:jsonand:proto.