Start fresh when re-adding a reviewer by seanprashad · Pull Request #288 · block/coplan

seanprashad · 2026-10-29T16:24:48Z

What changed and why

Removing a reviewer clears their review decisions across all reviewed versions. Re-adding them creates a fresh Pending request. Old response retries cannot restore a removed decision. Other active reviews remain unchanged.

Discussion comments and request/withdrawal audit history stay in place. API withdrawal still preserves review decisions.

Demo

Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>

Copilot

🟡 Changes recommended

Review removal leaves obsolete decision labels on surviving comments, and reviewer reassignment leaves open composers submitting to stale URLs that return 404.

2 open issues

What changed in this PR

This PR separates reviewer removal in CoPlan’s web UI from API withdrawal. Removal deletes prior review decisions so re-adding the reviewer creates a fresh Pending request, while preserving discussion comments and request/withdrawal history.

Changes:

Add permanent removal and replacement of withdrawn requests.
Reject stale request IDs and preserve other active reviews.
Update agent guidance and add service, request, and browser coverage.

File	Description
`spec/system/plan_reviews_spec.rb`	Covers re-addition, themes, history, and stale forms.
`spec/services/coplan/reviews/remove_spec.rb`	Tests removal, replacement, audit preservation, and concurrent retries.
`spec/requests/review_requests_spec.rb`	Checks authorization for permanent removal.
`spec/requests/api/v1/review_requests_spec.rb`	Verifies removed IDs cannot affect replacement requests.
`engine/app/views/coplan/reviews/_roster.html.erb`	Renames the action to “Remove reviewer.”
`engine/app/views/coplan/agent_instructions/guides/live.text.erb`	Documents removal events.
`engine/app/views/coplan/agent_instructions/guides/comments.text.erb`	Explains removal versus withdrawal and stale-ID handling.
`engine/app/services/coplan/reviews/request.rb`	Supports fresh replacements and identity-bound re-requests.
`engine/app/services/coplan/reviews/remove.rb`	Deletes requests and decisions while preserving request history.
`engine/app/javascript/controllers/coplan/review_tray_controller.js`	Sends removal and replacement options from web controls.
`engine/app/controllers/coplan/review_requests_controller.rb`	Routes web removal and guards updates against deleted requests.
`engine/app/controllers/coplan/api/v1/review_requests_controller.rb`	Binds updates to the original request identity.

_{Review effort: Balanced}

Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>

Copilot

🟢 Approval recommended

No active review issues are reported for the changes separating reviewer removal from API withdrawal.

No open issues 🎉

2 resolved since last review

_{Review effort: Balanced}

HamptonMakes · 2026-11-04T17:04:40Z

🤖 @codex review

chatgpt-codex-connector · 2026-11-04T17:04:57Z

Codex Review Summary

This comment shows the latest Codex review activity on this pull request.

Review	Status	Commit	Review trigger
📝 Code Review	✅ Completed 2026-11-04T17:08:48.936781Z	`9ca8527`	Manual request

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

chatgpt-codex-connector

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: 9ca85272e4

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

Open a pull request for review
Mark a draft as ready
Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

HamptonMakes

There is a gap where we are losing old approvals, which I thikn we should keep for provenance... I'll add that in a follow-on PR.

HamptonMakes · 2026-11-05T18:04:18Z

🤖 Follow-up requested by @HamptonMakes: #305 preserves historical approvals, change requests, notes, and attribution when a reviewer is removed, while re-addition still starts a fresh Pending assignment. It also records the removal actor and time. This is a standalone PR against main. The gap in this merged PR is that removal deletes earlier decisions; #305 prevents future loss but cannot recover decisions already deleted. Local regression tests pass; CI and automated reviews are running on the follow-up.

* origin/main: fix(engine): toggle task checkboxes only from the box itself (block#300) Put the plan title on the document (block#299) Look up a plan by its address in the API (block#301) Show discussion avatars in the page margin (block#291) Start fresh when re-adding a reviewer (block#288)

seanprashad added 2 commits October 29, 2026 12:24

Restore removed reviewers when re-added

ed9b185

Start fresh after removing a reviewer

729a7c6

seanprashad changed the title ~~Restore removed reviewers when re-added~~ Start fresh when re-adding a reviewer Oct 29, 2026

Limit resets to explicit reviewer reassignment

d46388f

seanprashad marked this pull request as ready for review October 29, 2026 18:58

seanprashad requested a review from HamptonMakes as a code owner October 29, 2026 18:58

seanprashad added 2 commits October 29, 2026 15:33

Exercise reviewer removal with real request history

f46f097

Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>

Preserve legacy request audit and removal events

b235f4f

Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>

HamptonMakes requested a balanced review from Copilot November 2, 2026 19:47

Copilot started reviewing on behalf of HamptonMakes November 2, 2026 19:48

View session

HamptonMakes reviewed Nov 2, 2026

View reviewed changes

Comment thread engine/app/controllers/coplan/api/v1/review_requests_controller.rb Resolved

HamptonMakes reviewed Nov 2, 2026

View reviewed changes

Comment thread engine/app/controllers/coplan/api/v1/review_requests_controller.rb Resolved

Copilot AI reviewed Nov 2, 2026

View reviewed changes

Comment thread engine/app/javascript/controllers/coplan/review_tray_controller.js Resolved

Comment thread engine/app/services/coplan/reviews/remove.rb Resolved

seanprashad added 3 commits November 2, 2026 15:54

Keep review drafts current after reassignment

417a01d

Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>

Merge main to resolve the CI runner conflict

3da4ec4

Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>

Invalidate approvals when review requests change

510bb7d

Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>

seanprashad requested a review from HamptonMakes November 2, 2026 21:13

seanprashad added 3 commits November 2, 2026 16:23

Ignore results from removed review requests

efed4fe

Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>

Refresh discussions after reviewer management

910ac4f

Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>

Ignore review refreshes after navigation

9ca8527

Signed-off-by: Sean Prashad <13009507+seanprashad@users.noreply.github.com>

seanprashad requested a balanced review from Copilot November 2, 2026 22:48

Copilot started reviewing on behalf of seanprashad November 2, 2026 22:48

View session

Copilot AI reviewed Nov 2, 2026

View reviewed changes

chatgpt-codex-connector Bot reviewed Nov 4, 2026

View reviewed changes

Comment thread engine/app/services/coplan/reviews/changed.rb Resolved

HamptonMakes approved these changes Nov 5, 2026

View reviewed changes

HamptonMakes merged commit b7737ae into block:main Nov 5, 2026
15 checks passed

This was referenced Nov 5, 2026

Preserve review history after reviewer removal #305

Draft

Tie approvals to versions and make resets optional #287

Merged

Navigation Menu

Repository navigation

Start fresh when re-adding a reviewer - #288

Start fresh when re-adding a reviewer#288
HamptonMakes merged 11 commits into
block:mainfrom
seanprashad:seanprashad/readd-reviewers

seanprashad commented Oct 29, 2026 •

edited

Loading

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Uh oh!

HamptonMakes commented Nov 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 4, 2026 •

edited

Loading

Uh oh!

chatgpt-codex-connector Bot left a comment

Uh oh!

Uh oh!

HamptonMakes left a comment

Uh oh!

Uh oh!

HamptonMakes commented Nov 5, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Conversation

seanprashad commented Oct 29, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

What changed and why

Demo

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟡 Changes recommended

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

🟢 Approval recommended

Uh oh!

HamptonMakes commented Nov 4, 2026

Uh oh!

chatgpt-codex-connector Bot commented Nov 4, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codex Review Summary

Uh oh!

chatgpt-codex-connector Bot left a comment

Choose a reason for hiding this comment

💡 Codex Review

Uh oh!

Uh oh!

HamptonMakes left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

HamptonMakes commented Nov 5, 2026

Uh oh!

Reviewers

Uh oh!

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

seanprashad commented Oct 29, 2026 •

edited

Loading

chatgpt-codex-connector Bot commented Nov 4, 2026 •

edited

Loading