Repository navigation
Refine the seeding of the MWCX generators - #512
Merged
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #512 +/- ##
=======================================
Coverage 94.80% 94.80%
=======================================
Files 56 56
Lines 9922 9922
Branches 214 215 +1
=======================================
Hits 9407 9407
Misses 495 495
Partials 20 20
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
Owner
|
Thanks. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Following up on #449, after the comments by Federico Busato on stream correlations, the reference implementation now suggests to fill the carry from the seed too, rather than setting it to one. Here the carry was already filled from the
SeedSequence, but it was set to one when the resulting state was not valid (between 0.02% and 0.27% of the seeds, depending on the generator); now the value used for the carry is always mapped into the range of valid carries, as in the reference implementation and in the other ports. The improvement is minor, but it keeps the seeding uniform. Note that this changes the MWCX streams for a given seed with respect to 2.5.x, so it probably needs a release note. The test data and the stable hashes have been updated.