Repository navigation
Conversation
Codex Review Summary: ✅ CompletedThis comment shows the latest Codex review activity on this pull request.
ℹ️ About Codex in GitHubYour team has set up Codex to review pull requests in this repo. Reviews are triggered when you
Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings. |
There was a problem hiding this comment.
💡 Codex Review
Here are some automated review suggestions for this pull request.
Reviewed commit: ce66388df8
ℹ️ About Codex in GitHub
Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you
- Open a pull request for review
- Mark a draft as ready
- Comment "@codex review".
If Codex has suggestions, it will comment; otherwise it will react with 👍.
Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".
| sessionId: _class.sessionId ?? undefined, | ||
| sectionNumber: _class.number, | ||
| }) | ||
| `${_class.subject};${_class.courseNumber};T;${_class.year}:${_class.semester};${_class.number}` |
There was a problem hiding this comment.
Preserve the session identifier when opening enrollment
For classes whose session ID is not 1, such as summer offerings, this URL now drops _class.sessionId. The restored legacy page's parseInputsFromUrl also ignores session IDs, so fetchEnrollment sends an undefined session and apps/backend/src/modules/enrollment/controller.ts defaults the query to session 1. Consequently, “Open in Enrollment” loads either no history or a different offering's history instead of the class being viewed. Preserve the session in both URL serialization and the restored page's parser.
Useful? React with 👍 / 👎.
| const time = timeFormatter.format( | ||
| moment.utc(0).add(duration).toDate() |
There was a problem hiding this comment.
Anchor tooltip times to the enrollment history start
When hovering over enrollment history, label is elapsed minutes since history[0].startTime, not a timestamp. Adding that duration to the Unix epoch and formatting it in Los Angeles time produces an unrelated clock time: the first point always displays Day 1 4:00 PM, regardless of when enrollment tracking actually began. The previous tooltip added the duration to firstTime; retain that anchor so the displayed time corresponds to the underlying enrollment record.
Useful? React with 👍 / 👎.
No description provided.