Skip to content

restore legacy enrollment - #1329

Open
Henrp wants to merge 1 commit into
mainfrom
henry/restore-legacy-enrollment
Open

Henrp wants to merge 1 commit into
mainfrom
henry/restore-legacy-enrollment

Conversation

@Henrp

@Henrp Henrp commented Nov 19, 2026

Copy link
Copy Markdown
Contributor

No description provided.

@chatgpt-codex-connector

chatgpt-codex-connector Bot commented Nov 19, 2026 •

Copy link
Copy Markdown
Codex Review Summary: ✅ Completed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ✅ Completed 2026-11-19T01:26:03.605494Z ce66388 PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector chatgpt-codex-connector Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

💡 Codex Review

Here are some automated review suggestions for this pull request.

Reviewed commit: ce66388df8

ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review".

If Codex has suggestions, it will comment; otherwise it will react with 👍.

Codex can also answer questions or update the PR. Try commenting "@codex address that feedback".

sessionId: _class.sessionId ?? undefined,
sectionNumber: _class.number,
})
`${_class.subject};${_class.courseNumber};T;${_class.year}:${_class.semester};${_class.number}`

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Preserve the session identifier when opening enrollment

For classes whose session ID is not 1, such as summer offerings, this URL now drops _class.sessionId. The restored legacy page's parseInputsFromUrl also ignores session IDs, so fetchEnrollment sends an undefined session and apps/backend/src/modules/enrollment/controller.ts defaults the query to session 1. Consequently, “Open in Enrollment” loads either no history or a different offering's history instead of the class being viewed. Preserve the session in both URL serialization and the restored page's parser.

Useful? React with 👍 / 👎.

Comment on lines +284 to 285
const time = timeFormatter.format(
moment.utc(0).add(duration).toDate()

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

P2 Badge Anchor tooltip times to the enrollment history start

When hovering over enrollment history, label is elapsed minutes since history[0].startTime, not a timestamp. Adding that duration to the Unix epoch and formatting it in Los Angeles time produces an unrelated clock time: the first point always displays Day 1 4:00 PM, regardless of when enrollment tracking actually began. The previous tooltip added the duration to firstTime; retain that anchor so the displayed time corresponds to the underlying enrollment record.

Useful? React with 👍 / 👎.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant