Skip to content

BER-77 Fix adding ratings from the profile - #1328

Open
ritamzico wants to merge 1 commit into
mainfrom
ritamzico/fix-add-rating-button
Open

ritamzico wants to merge 1 commit into
mainfrom
ritamzico/fix-add-rating-button

Conversation

@ritamzico

@ritamzico ritamzico commented Nov 16, 2026 •

Copy link
Copy Markdown
Contributor

Summary

Both “Add Rating” buttons on the profile opened a form with no selected course and no way to choose one, leaving semester selection and submission disabled. Add a searchable course picker using the existing CourseSelect component so users can choose a course, select its semester/instructor, and submit a rating.

Changing or clearing the course resets the semester. Previously rated courses are disabled in the picker, and forms with a fixed course retain their existing behavior.

Fixes BER-77.

Validation

  • Browser-tested in Chromium against an isolated local backend with real catalog data: course search, course-specific semester/instructor options, successful submission and profile refresh, switching courses, both add buttons, and editing an existing rating.
  • Confirmed previously rated courses are disabled and reopening the add form clears the selection.
  • Frontend TypeScript check passed.
  • Pre-push formatting and repository lint checks passed.

Screenshots

Search for a course

01-course-search

Select a semester and instructor for the chosen course

02-course-semesters

Submitted rating appears on the profile

03-rating-saved

@chatgpt-codex-connector

Copy link
Copy Markdown
Codex Review Summary: ❌ Failed

This comment shows the latest Codex review activity on this pull request.

Review Status Commit Review trigger
📝 Code Review ❌ Failed 2026-11-16T05:07:17.988689Z
We couldn’t complete this review. Comment @codex review to try again.
3b9efaf PR opened
ℹ️ About Codex in GitHub

Your team has set up Codex to review pull requests in this repo. Reviews are triggered when you

  • Open a pull request for review
  • Mark a draft as ready
  • Comment "@codex review" or "@codex security review".

Codex reacts with 👀 while any review is running, comments if it has suggestions, and reacts with 👍 once all reviews finish with no findings.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant