Repository navigation
spike: node runner resolve hook (do not merge) - #6
Closed
armando-navarro wants to merge 1 commit into
Closed
armando-navarro wants to merge 1 commit into
armando-navarro wants to merge 1 commit into
Conversation
The Node jasmine run loads every spec with import(), so an import of @angular/fire looked for an installed package and found none. A resolve hook, preloaded with --import, maps @angular/fire and its entries to the files the built exports map names under dist/packages-dist. Nothing is written into node_modules, and the library's own firebase/app import resolves to the same copy the spec uses.
Owner
Author
|
CI rehearsal done: every job green on ubuntu, macOS and Windows. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
CI rehearsal on the fork only. Lets the Node jasmine specs import the built @angular/fire through a resolve hook, with one throwaway spec that imports it. Checks the hook on all three operating systems. Not for merging.