Repository navigation
Retire the old Gradle build (#252) - #261
Merged
Merged
Conversation
The template is built by arc42-generator (make, Docker), which also checks every pull request here. Removed what only the old Gradle build used: - build.gradle, settings.gradle, gradle.properties, gradlew, gradlew.bat, gradle/ (wrapper) - Dockerfile, Dockerfile.build, docker-compose.yml, .dockerignore: they only ran ./gradlew - ZH/pdf-theme/ and ZH-TW/pdf-theme/: Noto Sans SC fonts (40 MB each) and themes; the generator renders Chinese PDFs with its own theme and fallback font (arc42-generator#82) - Gradle entries in .gitignore README: the local build section now describes the preview with arc42-generator, the directory structure and how to add a language. Git history is not rewritten. Closes #252 Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #252. The template is now built only by arc42-generator (make + Docker), which also produces the downloads and checks every pull request here (Golden master validation).
Removed (only the old Gradle build used them)
build.gradle,settings.gradle,gradle.properties,gradlew,gradlew.bat,gradle/(wrapper).Dockerfile,Dockerfile.build,docker-compose.yml,.dockerignore. All of them only ran./gradlew(build, validate, an nginx preview).ZH/pdf-theme/andZH-TW/pdf-theme/: themes and the four Noto Sans SC fonts, 40 MB each, byte-identical. Onlybuild.gradleread them..gitignore: the Gradle entries.A checkout gets about 80 MB smaller. Git history is not rewritten, so the fonts stay in the history.
README
The section Build a Local Version replaces the Gradle and Docker instructions with:
make image, check out your branch in its submodule,make generate FORMAT=html|pdf,make templates OPTS=--lint=warn);revdate-isoandother-formats/);Checks (from #252)
git grep -i 'gradle\|pdf-theme\|Dockerfile\|docker-compose': no references left.make generate FORMAT=pdf): 0 lint errors, no diagnostics.DroidSansFallback, and I checked a ZH-TW page visually: the Chinese text renders.🤖 Generated with Claude Code