[Pijukatel]

impit 15.1 includes updates related to compromised CA certificates

[codecov]

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 95.53%. Comparing base (96f21b1) to head (fe233de).
⚠️ Report is 1 commits behind head on master.

Additional details and impacted files

@@           Coverage Diff           @@
##           master    #1160   +/-   ##
=======================================
  Coverage   95.53%   95.53%           
=======================================
  Files          61       61           
  Lines        5974     5974           
=======================================
  Hits         5707     5707           
  Misses        267      267           

Flag	Coverage Δ
integration	90.74% <ø> (+0.10%)	⬆️
unit	89.78% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

☔ View full report in Codecov by Harness.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:

• ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
• 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

[vdusek]

This is technically a breaking change. TBH I'm not sure the bump of minimal version is necessary.

[Pijukatel]

This is technically a breaking change. TBH I'm not sure the bump of minimal version is necessary.

It is bumping only impit, and that has no other Python dependencies. So it would be breaking only in cases someone locks impit itself to older versions that use the compromised certificates. Why would we want to support such usecase?

[vdusek]

OK, since this is about the TLS trust in the HTTP layer, which I'd say is apify-client's job, I guess the bump is justified. Also as you said, the chance it breaks anything is very low.

I also renamed the PR so it shows up in the changelog and says what changes and why.

Approving. Let's also drop the upper bound (#1163) as part of the next release.