Repository navigation
ci: reject unused dependencies - #336
Merged
Merged
Conversation
Remove dependencies that are not referenced by their crates and add a cargo-machete job so new unused entries fail CI. Replace the last lazy_static use with std::sync::LazyLock, which is available in the std-only TLS server TA. Keep cfg_block, whose conditional imports are clearer than repeated cfg attributes. Drop libc from the CA examples, strum and uuid where unused, and clean the unused cargo-optee and eth_wallet dependencies. Refresh the affected lockfiles and fix the formatting issues found in eth_wallet.
Cache the Cargo registry download cache and index in the Rust build jobs. Only crate tarballs are cached; target directories are left out because they exceed the repository cache quota. Install rustup without the default stable toolchain and remove the uninstall/install cycle from setup.sh. The pinned toolchain from rust-toolchain.toml is installed afterwards. Do not change make parallelism; Cargo still uses the existing -j2 to avoid excessive concurrent compilation.
ivila
force-pushed
the
deps/remove-unused-dependencies
branch
from
November 3, 2026 10:03
3472626 to
e8db12c
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove dependencies that are not referenced by their crates and add a cargo-machete job so new unused entries fail CI.
Replace the last lazy_static use with std::sync::LazyLock, which is available in the std-only TLS server TA. Keep cfg_block, whose conditional imports are clearer than repeated cfg attributes.
Drop libc from the CA examples, strum and uuid where unused, and clean the unused cargo-optee and eth_wallet dependencies. Refresh the affected lockfiles and fix the formatting issues found in eth_wallet.