Repository navigation
fix(zset): reject non-positive numkeys in ZUNIONSTORE, ZINTERSTORE and ZDIFFSTORE - #3738
Open
Anurag-S1ngh wants to merge 2 commits into
Open
Anurag-S1ngh wants to merge 2 commits into
Anurag-S1ngh wants to merge 2 commits into
Conversation
…d ZDIFFSTORE The store variants accepted numkeys 0 and left the key list empty, so ZSet::Diff and ZSet::Inter read keys[0] and crashed the server. Reject non-positive numkeys in both parsers, matching ZDIFF and ZINTER.
|
Hi @Anurag-S1ngh, Thank you for your pull request. Please review our Contributing Guide. Please make sure you understand your changes and explain your reasoning in this pull request. Low-quality pull requests may be closed. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
ZUNIONSTORE,ZINTERSTOREandZDIFFSTOREacceptednumkeys 0and left the key list empty.ZSet::DiffandZSet::Interthen readkeys[0], crashing the server with a SIGSEGV.Changes
numkeysinCommandZUnionStore::ParseandCommandZDiffStore::Parsewithvalue is out of range, must be positive, matchingZDIFFandZINTER.Testing
tests/gocase/unit/type/zsetcovering0and-1for all three commands and asserting no destination key is written../x.py test go build -run TestZSetpasses.clang-formatclean,golangci-lintreports 0 issues.Closes #3729