Repository navigation
IGNITE-29153 Move BinaryUtils read helpers to BinaryReaderExImpl - #13695
Merged
Merged
Conversation
…ller through it GridBinaryMarshaller no longer calls the package-private BinaryUtils#unmarshal directly, which lets the read helpers leave the binary API module. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
…derExImpl The unmarshal switch and its doRead* helpers were reachable only from binary-impl once GridBinaryMarshaller went through BinariesFactory. They move verbatim as static methods: the 31 helpers used only by the reader become private members of BinaryReaderExImpl, and the four shared with the builder and offheap object (checkProtocolVersion, length, doReadClassName, doReadOptimized) move to BinaryImplUtils. doReadStringArray stays in BinaryUtils because the thin client calls it. Co-Authored-By: Claude Fable 5.1 <noreply@anthropic.com>
NSAmelchev
approved these changes
Oct 16, 2026
Contributor
TCBot Test Analysis
Possible Blockers (0)No blockers found. New Tests (0)No new tests found. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Part of IGNITE-25090 (extract binary implementation from ignite-core). Sub-task: https://issues.apache.org/jira/browse/IGNITE-29153
What. Two commits, no behaviour change:
BinariesFactory#unmarshalis added andGridBinaryMarshallergoes through it instead of calling the package-privateBinaryUtils#unmarshaldirectly.doRead*helpers move out ofignite-binary-api. The 31 helpers used only by the reader become private static members ofBinaryReaderExImpl;checkProtocolVersion,length,doReadClassNameanddoReadOptimized, which the builder and the offheap object also use, move toBinaryImplUtils.doReadStringArraystays inBinaryUtilsbecause the thin client calls it.Why. Once the marshaller reaches
unmarshalthrough the factory, the whole read family is referenced only fromignite-binary-impl, so it no longer belongs in the API module. Method bodies move verbatim; the diff outsideBinaryUtils/BinaryReaderExImplis four one-line call-site changes plus imports.Checked.
ignite-binary-api,ignite-binary-impl,ignite-corecompile; checkstyle passes on all three; core binary suites (BinaryMarshallerSelfTest, builder, enums, arrays, heap/offheap fields) pass, 857 tests.🤖 Generated with Claude Code