Skip to content

IGNITE-29117 Both engines must be available. Calcite default. - #13692

Merged
nizhikov merged 16 commits into
apache:masterfrom
nizhikov:IGNITE-29117-4
Oct 16, 2026
Merged

nizhikov merged 16 commits into
apache:masterfrom
nizhikov:IGNITE-29117-4

Conversation

@nizhikov

Copy link
Copy Markdown
Contributor

Thank you for submitting the pull request to the Apache Ignite.

In order to streamline the review of the contribution
we ask you to ensure the following steps have been taken:

The Contribution Checklist

  • There is a single JIRA ticket related to the pull request.
  • The web-link to the pull request is attached to the JIRA ticket.
  • The JIRA ticket has the Patch Available state.
  • The pull request body describes changes that have been made.
    The description explains WHAT and WHY was made instead of HOW.
  • The pull request title is treated as the final commit message.
    The following pattern must be used: IGNITE-XXXX Change summary where XXXX - number of JIRA issue.
  • A reviewer has been mentioned through the JIRA comments
    (see the Maintainers list)
  • The pull request has been checked by the Teamcity Bot and
    the green visa attached to the JIRA ticket (see tab PR Check at TC.Bot - Instance 1 or TC.Bot - Instance 2)

Notes

If you need any help, please email dev@ignite.apache.org or ask anу advice on http://asf.slack.com #ignite channel.

@nizhikov
nizhikov requested a review from ptupitsyn as a code owner October 15, 2026 09:42
/** */
@Test
public void testSelect() throws Exception {
List<List<Object>> res = executeQuery(conn, "SELECT id, val FROM test ORDER BY id");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Shouldn't we also ensure that query_engine is dfltEngine?

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Check added.

@nizhikov
nizhikov requested a review from isapego as a code owner October 15, 2026 11:47
@ignitetcbot

Copy link
Copy Markdown
Contributor

TCBot Test Analysis

Possible Blockers (33)

  • Thin client: Node.js: 1 tests
    • execute examples >: SqlExample - Test has low fail rate in base branch 0,0% and is not flaky
  • Thin client: Python: 32 tests
    • tests.test_examples.test_examples(/opt/teamcity/work/425d7af4e9aa99d9/ignite-python-thin-client/tests/__/examples/async_sql_py) - Test has low fail rate in base branch 0,0% and is not flaky
    • tests.test_examples.test_examples(/opt/teamcity/work/425d7af4e9aa99d9/ignite-python-thin-client/tests/__/examples/sql_py) - Test has low fail rate in base branch 0,0% and is not flaky
    • tests.test_examples.test_examples(/opt/teamcity/work/425d7af4e9aa99d9/ignite-python-thin-client/tests/__/examples/read_binary_py) - Test has low fail rate in base branch 0,0% and is not flaky
    • tests.common.test_binary.test_sql_read_as_binary - Test has low fail rate in base branch 0,0% and is not flaky
    • tests.common.test_binary.test_sql_read_as_binary_async - Test has low fail rate in base branch 0,0% and is not flaky
    • tests.common.test_datatypes.test_uuid_representation(d57babad-7bc1-4c82-9f9c-e72841b92a85) - Test has low fail rate in base branch 0,0% and is not flaky
    • tests.common.test_datatypes.test_uuid_representation(5946c0c0-2b76-479d-8694-a2e64a3968da) - Test has low fail rate in base branch 0,0% and is not flaky
    • tests.common.test_datatypes.test_uuid_representation(a521723d-ad5d-46a6-94ad-300f850ef704) - Test has low fail rate in base branch 0,0% and is not flaky
    • tests.common.test_datatypes.test_uuid_representation_async(d57babad-7bc1-4c82-9f9c-e72841b92a85) - Test has low fail rate in base branch 0,0% and is not flaky
    • tests.common.test_datatypes.test_uuid_representation_async(5946c0c0-2b76-479d-8694-a2e64a3968da) - Test has low fail rate in base branch 0,0% and is not flaky
    • ... and 22 more test blockers

New Tests (0)

No new tests found.

/** */
@Test
public void testSelect() throws Exception {
checkEngine(grid(0).getOrCreateCache(DEFAULT_CACHE_NAME), dfltEngine, "SELECT QUERY_ENGINE()");

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

checkEngine uses jdbc thin connection, but not conn

Copy link
Copy Markdown
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed.

@nizhikov
nizhikov merged commit 78f4b40 into apache:master Oct 16, 2026
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants