Repository navigation
Conversation
Expose PY_SCALAR_UDF_FAMILY, PY_AGG_UDF_FAMILY, and PY_WINDOW_UDF_FAMILY so downstream consumers (e.g. Ballista's Python client) can recognise inline Python UDF payloads without duplicating the magic bytes. Closes apache#1817.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Which issue does this PR close?
Closes #1817.
Rationale for this change
Ballista's Python client wraps datafusion-python's
PythonLogicalCodecand needs to recognise inline Python UDF payloads so it can route them to that codec. The family prefixes it matches on werepub(crate)incrates/core/src/codec.rs, so Ballista had to keep its own copies and would silently break if the wire format changed here.What changes are included in this PR?
PY_SCALAR_UDF_FAMILY,PY_AGG_UDF_FAMILY, andPY_WINDOW_UDF_FAMILYfrompub(crate)topub.They are reachable as
datafusion_python::codec::PY_*_UDF_FAMILY(pub mod codecwas already public). No otherpub(crate)wire-format constants (WIRE_VERSION_*,CHAINED_*, etc.) are exposed.Are there any user-facing changes?
Yes — additive Rust API only. Downstream crates can import the three family prefixes instead of duplicating the magic bytes. No Python API change and no behaviour change.
AI assistance
AI-assisted implementation (agent harness); change reviewed for minimality against #1817.
Tests
cargo check -p datafusion-python(pass)cargo fmt -p datafusion-python -- --check(pass; only unstable rustfmt.toml warnings unrelated to this change)