Repository navigation
Fix enable_url_table session sharing - #1815
Open
dajiaohuang wants to merge 1 commit into
Open
dajiaohuang wants to merge 1 commit into
dajiaohuang wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #1708
Rationale
enable_url_table()previously returned a handle backed by a separateSessionContextallocation while retaining the session ID. This allowed live handles to diverge in state and could invalidate weak FFI task-context providers when callers reassigned the returned handle.Changes
state_ref()and return a handle sharing the sameArc<SessionContext>.User-facing change
Both the original handle and the returned handle now observe URL-table enablement and subsequent state changes. Reassigning the result remains valid. This is a behavioral API change; the
api changelabel is required. I attempted to apply the label, but GitHub deniedAddLabelsToLabelablefor this account, so the label remains unapplied.Validation
cargo check --features substrait --package datafusion-python— passed.pytest python/on Windows — 1,626 passed, 11 skipped, 2 failed. The failures are in theread_arrowandregister_arrowdoctests:TemporaryDirectorycleanup raisesWinError 32whiledata.arrowis still held open.ty, Rust fmt, and codespell.