Repository navigation
iio: trx-rf: ad9088: Support IC13 - #3639
Merged
Merged
Conversation
This comment was marked as resolved.
This comment was marked as resolved.
gastmaier
force-pushed
the
staging/ad9084/ic13
branch
2 times, most recently
from
October 30, 2026 18:38
0b9b1e5 to
a011d85
Compare
gastmaier
force-pushed
the
staging/ad9084/fnco_ffh_profile
branch
from
October 30, 2026 18:42
ffad15a to
5365496
Compare
gastmaier
force-pushed
the
staging/ad9084/ic13
branch
from
October 30, 2026 18:42
a011d85 to
d1e1bb5
Compare
nunojsa
force-pushed
the
staging/ad9084/ic13
branch
from
November 2, 2026 16:58
d1e1bb5 to
932d997
Compare
gastmaier
marked this pull request as ready for review
November 3, 2026 10:33
gastmaier
requested review from
CiprianRegus,
amiclaus,
btogorean,
buha,
chegbeli,
danmois,
dbogdan,
machschmitt,
mhennerich,
nunojsa,
rbolboac and
stefpopa
as code owners
November 3, 2026 10:33
Collaborator
|
@gastmaier any special reason to merge this into a staging branch?! |
gastmaier
changed the base branch from
staging/ad9084/fnco_ffh_profile
to
main
November 3, 2026 15:19
Collaborator
Author
nothing in particular, just wanted to use the new stack pr feature 👉👈 |
nunojsa
approved these changes
Nov 11, 2026
| dmas = <&rx_dma_b 0>; | ||
| dma-names = "rx"; | ||
| clocks = <&trx0_ad9084 0>; /* FIXME */ | ||
| clocks = <&trx0_ad9084 2>; |
Collaborator
There was a problem hiding this comment.
Could be a different patch given it's a different arch. But no strong feelings
clock-cells takes <&phandle N>, so set from 0 to 1. Also change dev_clk-clock-scales to "-clock-scales$" pattern to encompass also the sample clock scales. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
gastmaier
force-pushed
the
staging/ad9084/ic13
branch
from
November 12, 2026 13:34
932d997 to
47238e0
Compare
The TX channel map took JESD pair k as FDUC k and looked it up in the FDUC->CDUC summer, falling back to CDUC0 when no CDUC summed it; problematic with FDUC interpolation 1 (1xNx). In 1xNx pair k feeds the k-th FDUC summed into a CDUC, in CDUC order, not FDUC k. It would also fallback to CDUC0, then labelled it FDUC1->CDUC0->DAC0, and its CNCO/FNCO attributes programmed CDUC0 (channel 0's) and FDUC1 (unused), so channel 1's NCOs could not be reached. In 1xNx on 4T4R, take the k-th summed FDUC. When a channel's FDUC is still not summed into any CDUC, label it Side-X:FDUCn->unrouted and return no channel map. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
Register rx_sampl_clk_link2 and tx_sampl_clk_link2 (outputs 2 and 3), with rates from side B's profile and their own clock scales, as ad9081 does for its second link. Allows asymmetric at different rates and resolves 'fixme' were side A clock rates were used for side B. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
Add 204C_8T8R_M8_L2_NP16_8p0_4x8.bin and 204C_M4_L12_NP12_20p0_4x1.bin to CONFIG_EXTRA_FIRMWARE. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
Point the side B TPL cores (rx_b, tx_b) to the side B sample clock outputs of the converter, 2 and 3, instead of side A's. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
Add the VCU118 devicetree for the AD9088 default 8T8R use case (204C_8T8R_M8_L2_NP16_8p0_4x8: M=8, L=2, NP=16 per side at 16.5 Gbps), based on the AD9084 one. Needs the asymmetric HDL build, 16.5 Gbps uses the QPLL1 in full-rate mode (VCO at 8.25 GHz from the 250 MHz FPGA_REFCLK). The QPLL0 (VCO 9.8 to 16.375 GHz) can't generate it. Signed-off-by: Jorge Marques <jorge.marques@analog.com>
Add the 204C_M4_L12_NP12_20p0_4x1 use case (IC13: M=4, L=12, NP=12, 20.625 Gbps, DAC 20 GS/s, 4x1), asymmetric. hdl/projects/ad9084_ebz/vcu118$ make \ JESD_MODE=64B66B ASYMMETRIC_A_B_MODE=1 \ RX_LANE_RATE=20.625 TX_LANE_RATE=20.625 \ RX_B_LANE_RATE=20.625 TX_B_LANE_RATE=20.625 \ RX_JESD_M=4 TX_JESD_M=4 RX_JESD_L=12 TX_JESD_L=12 \ RX_JESD_S=2 TX_JESD_S=2 RX_JESD_NP=12 TX_JESD_NP=12 \ RX_B_JESD_M=4 TX_B_JESD_M=4 RX_B_JESD_L=12 TX_B_JESD_L=12 \ RX_B_JESD_S=2 TX_B_JESD_S=2 RX_B_JESD_NP=12 TX_B_JESD_NP=12 Signed-off-by: Jorge Marques <jorge.marques@analog.com>
gastmaier
force-pushed
the
staging/ad9084/ic13
branch
from
November 12, 2026 13:38
204241a to
aad7dfc
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR Description
Resolve quite a few quirks to support IC13 4G IBW; including distinct lane rates on side A and B (known 'fixme'), clock scale for the lane rate itself, and a mapping fix for case 1xNx, where the n-th FDUC wouldn't sum into any CDUC, then silently fallback to CDUC0, which made thing worse, since the NCO wouldn't be reached at all.
PR Type
PR Checklist