Repository navigation
Conversation
647b8ea to
cacc7d4
Compare
LLM reviewThis series adds MAX9295D serializer support and multi-camera-over-one-GMSL-link run: 32879832079
|
cacc7d4 to
82dbf0d
Compare
82dbf0d to
ced5341
Compare
ced5341 to
b74717a
Compare
b74717a to
fd537dc
Compare
fd537dc to
bd98191
Compare
btogorean
left a comment
There was a problem hiding this comment.
Please split commit "media: i2c: maxim-serdes: add MAX9295D support" in 2 separate commits. One adding support for multiple cameras per GMSL link and the other one adding support for MAX9295D
* Add continuous clock option in the ov5640 driver. * Add continuous clock flag in ov5640.dtsi.in. Signed-off-by: Adrian Costea <Adrian.Costea@analog.com>
Added continuous clock option in the imx708 driver. Added continuous clock flag in imx708.dtsi.in. Signed-off-by: Adrian Costea <Adrian.Costea@analog.com>
Add deserializer support for routing multiple camera streams arriving over a single GMSL link to separate pipes, and let a serializer expose more than one camera input. Update the DTS generator so a serializer's output port index follows the number of connected cameras. Signed-off-by: Adrian Costea <Adrian.Costea@analog.com>
bd98191 to
3a281b0
Compare
3a281b0 to
c2b7e9d
Compare
Add the maxim,max9295d compatible, handled by the max96717 driver. Signed-off-by: Adrian Costea <Adrian.Costea@analog.com>
Add MAX9295D serializer support in max96717. Add a MAX9295D template and example config to the DTS generator. Signed-off-by: Adrian Costea <Adrian.Costea@analog.com>
c2b7e9d to
91aae0b
Compare
|
Hi ADI team, Following the Hawk discussion with Thomas, here are the technical findings from integrating the MAX9295D support in Our setup is: AR0234 left ── CSI input A ─┐ The requirement is reliable capture from both sensors, in free-running mode and with internally generated FSYNC. The
References: 0002*patch The existing deserializer code negotiates only the first pipe on each link. Both serializer stream-ID helpers also struct max_ser_pipe *pipe = &ser->pipes[0]; Consequently, the second stream depends on matching defaults instead of having its transport ID negotiated. The MAX96724 descriptor also needs the unique-ID setting already used by MAX96716A. In the ADI branch’s layout, the static const struct max_des_ops max96724_ops = {
That corrects the initial assignments, but the helpers must also resolve the actual routed transmit pipe. Our static struct max_ser_pipe * } The setter/getter take the source pad and stream and perform this lookup under the serializer’s active-state lock. For ret = max_ser_get_stream_id(hw.source->sd, hw.source->pad, It then programs the matching receive pipe. This handles, for example, input B exposing software stream 0 while The full patch also validates IDs, rejects changes to running pipes, updates cached IDs only after successful writes,
Reference: 0003*patch The generic driver programs each receive pipe’s link and transport ID, but MAX96724’s STREAM_SEL_ALL automatic- In max96724_set_pipe_enable(), our fix sets the selection policy before enabling reception: if (enable && priv->info->supports_pipe_stream_autoselect) { return regmap_assign_bits(priv->regmap, MAX96724_VIDEO_PIPE_EN, This clears STREAM_SEL_ALL in pixel mode while retaining the existing tunnel-mode policy. The capability check
Reference: 0007* The existing implementation can program FSYNC when an inactive control changes and can start it before the upstream Our fix caches the requested configuration while inactive and determines FSYNC transitions from all configured active old_fsync_active = max_des_all_streams_active(priv, start_fsync = !old_fsync_active && new_fsync_active; max_des_all_streams_active() compares the requested stream masks with the expected masks collected from active Receive pipes are enabled as their streams are requested. The generator starts only after the final required upstream if (enable) { } The full patch also stops FSYNC before disarming the first participating sensor, includes error-path cleanup, and
Reference: 0008* This correction resolved the remaining one-eye FSYNC failure. With both streams arriving over physical link A, AUTO_FS_LINKS in register 0x04AF allowed one pipe to output frames The FS_LINK_x bits select video pipes. Both bits are needed even though both streams arrive over the same physical The patch adds: #define MAX96724_FSYNC_15_FS_LINKS GENMASK(3, 0) In max96724_set_fsync(), the mask defaults to the existing automatic policy. For variants with the new fsync_per_pipe unsigned int fs_links = MAX96724_FSYNC_15_AUTO_FS_LINKS; /* Within the enabled-FSYNC configuration path: */ ret = regmap_write(priv->regmap, MAX96724_FSYNC_15, The capability is enabled for MAX96724/F, preserving MAX96712’s existing behavior. Please carry this together with patch 0007, so all participating pipes are enabled before the mask is computed. The
Reference: 0001 / 61a89bf5ad64. Our camera peripherals use the serializer’s i2c-gate bus. Overlay removal through xmutil/dfx-mgrd caused: i2c_atr_del_adapter Probe had allocated a mux, but teardown looked up i2c-gate again after the node had been detached. It then selected The corrected selection is: static void max_ser_i2c_adapter_deinit(struct max_ser_priv *priv) The cleanup helpers guard NULL resources, remove their child adapters, and clear the saved pointers after cleanup.
References: 0004 / bc7d06c26230 The MAX9295D binding needs its compatible-specific port layout: Interface MAX9295D port The existing single-input binding describes port 1 as the GMSL output. Patch 0004 corrects this while preserving the // references Could you please fold these fixes, or equivalent implementations, into the maintained ADI driver and next upstream Thanks, |

PR Description
Serializer (max96717.c, max_ser.c)
Deserializer (max_des.c, max9296a.c)
Sensors (imx708.c, ov5640.c)
PR Type
PR Checklist