Repository navigation
Conversation
…adapter - lib/upload.js: when a file exceeds opt.max, the error callback referenced the undefined variable 'file' instead of 'files', so it threw a ReferenceError instead of reporting 'File size is too large.' - lib/level.js: 'soul' was assigned without a declaration, leaking an implicit global (and throwing in strict mode).
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Two small bugs found with
eslint --rule no-undef:lib/upload.js: when a dropped file is larger thanopt.max, the error callback doesfile: file[i], but the variable isfiles. Instead of callingcb({err: "File size is too large."}), it throwsReferenceError: file is not defined. Changed tofiles[i].lib/level.js:soulis assigned in thegethandler without being declared, so it leaks as an implicit global (and throws in strict mode / ESM bundles). Declared it alongsidelex.