Repository navigation
Network: Fail start if network connection fails - #15
Open
ReverseStatic wants to merge 1 commit into
Open
ReverseStatic wants to merge 1 commit into
ReverseStatic wants to merge 1 commit into
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
HyperVNetwork::start()ignored the result ofconnectNetwork(), so the interface was attached and registered even when buffer setup failed andinitializeRNDIS()never ran. When configd then enables the interface, the driver dereferences the null_rndisLockand panics:This change makes
start()fail when the connection fails, so the guest boots without networking instead of panickingThis does not fix why the connection fails. In my case that was GPADL creation hitting
HV_STATUS_INSUFFICIENT_BUFFERS, which #13 addresses; #12 may also be relatedTested on mac 15.8.1 vm on w11 (amd, 8 vcpus)