Repository navigation
Prohibit NULL code points in written strings - #42
Merged
Merged
Conversation
lberrymage
added
the
buf skip breaking
|
The latest Buf updates on your PR. Results from workflow Buf CI / buf (pull_request).
|
The Accrescent server supports PostgreSQL as its production data store backend. PostgreSQL generally supports storing UTF-8 in its text type; however, due to historical limitations, it does not support storing NULL code points in text values. As a result, any attempted write to a string from the console API which contains a NULL code point cannot be stored as-is; instead, the server returns an internal server error since the error occurs at the database level. To prevent such errors from occurring while still saving API input as-is, prohibit NULL code points in written strings via protovalidate so that they are rejected as soon as possible. This change also removes AppDraftListingText from the request path; it is returned only in responses so that we can enforce NULL-freeness on the request path but not guarantee it in responses in case we're able to accept NULL code points in the future.
lberrymage
force-pushed
the
no-null-writes
branch
from
October 30, 2026 18:56
807b15b to
fb0ea93
Compare
lberrymage
enabled auto-merge (rebase)
October 30, 2026 18:59
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The Accrescent server supports PostgreSQL as its production data store backend. PostgreSQL generally supports storing UTF-8 in its text type; however, due to historical limitations, it does not support storing NULL code points in text values. As a result, any attempted write to a string from the console API which contains a NULL code point cannot be stored as-is; instead, the server returns an internal server error since the error occurs at the database level.
To prevent such errors from occurring while still saving API input as-is, prohibit NULL code points in written strings via protovalidate so that they are rejected as soon as possible.
This change also removes AppDraftListingText from the request path; it is returned only in responses so that we can enforce NULL-freeness on the request path but not guarantee it in responses in case we're able to accept NULL code points in the future.