Repository navigation
wasm2c: support mmap on non default memory size - #2910
Merged
Merged
Conversation
Collaborator
Author
|
Note: although this PR adds code, it unifies code paths. This will in turn simplify the next set of changes I've planned which will optimize perf for memory32 on 32-bit systems. |
sbc100
reviewed
Oct 29, 2026
shravanrn
force-pushed
the
mmap-nondefault-memsize
branch
from
October 29, 2026 22:27
cfd2c82 to
b85bd0c
Compare
Collaborator
Author
|
@sbc100 Please have a look and approve the PR when possible. I am waiting to land a couple more changes that build on this. |
shravanrn
force-pushed
the
mmap-nondefault-memsize
branch
from
November 2, 2026 19:36
b85bd0c to
580a375
Compare
shravanrn
enabled auto-merge (rebase)
November 2, 2026 19:36
shravanrn
force-pushed
the
mmap-nondefault-memsize
branch
from
November 2, 2026 19:38
580a375 to
5104b1b
Compare
sbc100
approved these changes
Nov 2, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
wasm2c currently falls back to malloc on non default page size even if
WASM_RT_USE_MMAP. This unfortunately complicates the runtime unnecessarily. This PR unifies howWASM_RT_USE_MMAPis handled for all Wasm memory 32 allocations.