Repository navigation
Sync with wasm-tools a bit more, clarify task.return & borrows - #737
Merged
Merged
Conversation
This is a few more minor edits to the spec from comparing the implementation in wasm-tools against the spec. The changes here are: * Encoding rules for types within a core module type have been updated to statically disallow core-modules-in-core-modules. This matches wasm-tools' behavior where within a core module the funky `0x00` prefix isn't needed for GC types, it's only within components that's needed. Minor `binary.wast` updates were made for this. * The `async` option on `canon lower` no longer unconditionally requires `memory`. This is already tested, wasm-tools already implements this behavior, so this syncs the explainer with the tests. * An explicit validation rule was added to disallow `borrow`s in the `$t` passed to the `task.return` intrinsic. This already wouldn't work anywhere because it couldn't match a function signature, but it seems reasonable to go ahead and statically disallow it here to avoid runtimes having to worry about it.
Member
|
Oh, one other thought: might be good to throw an |
WorldSEnder
pushed a commit
to WorldSEnder/wasm-tools
that referenced
this pull request
Oct 7, 2026
…#2761) Adjusting for the changes in WebAssembly/component-model#737
Collaborator
Author
|
can do! |
30 of 31 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This is a few more minor edits to the spec from comparing the implementation in wasm-tools against the spec. The changes here are:
Encoding rules for types within a core module type have been updated to statically disallow core-modules-in-core-modules. This matches wasm-tools' behavior where within a core module the funky
0x00prefix isn't needed for GC types, it's only within components that's needed. Minorbinary.wastupdates were made for this.The
asyncoption oncanon lowerno longer unconditionally requiresmemory. This is already tested, wasm-tools already implements this behavior, so this syncs the explainer with the tests.An explicit validation rule was added to disallow
borrows in the$tpassed to thetask.returnintrinsic. This already wouldn't work anywhere because it couldn't match a function signature, but it seems reasonable to go ahead and statically disallow it here to avoid runtimes having to worry about it.