Repository navigation
Tweak some implementation details/wording - #736
Merged
Merged
Conversation
* Clarify that `context.{get,set}` slot 1 is gated behind the threading
emoji.
* Clarify that for `thread.new-indirect` the table type must be exactly
`funcref`, not "matches" in the spec-subtyping-sense.
This is intended to match the implementation in `wasm-tools` which I
believe is roughly desired here as well, but these can also be tweaked
in `wasm-tool` as well.
lukewagner
approved these changes
Oct 6, 2026
Member
|
Thanks! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
context.{get,set}slot 1 is gated behind the threading emoji.thread.new-indirectthe table type must be exactlyfuncref, not "matches" in the spec-subtyping-sense.This is intended to match the implementation in
wasm-toolswhich I believe is roughly desired here as well, but these can also be tweaked inwasm-toolas well.