Repository navigation
[TS] Preserve independent bodies of classes with unsupported definitions - #446
Merged
Merged
Conversation
Contributor
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Class definitions with computed names or unresolved runtime bases currently remove the entire class DTO, including independent method bodies. This became reachable through
unsupportedClassDeclarationReasonin #443 and rejected 23 previously admitted TS200 targets.Retain ordinary named bodies and fields for analysis on an existing symbolic receiver. Keep the module declaration, runtime class value/exports, constructor and instance/static lifecycle explicitly unsupported. Computed members never become
%computedstorage. Initializer closures retain body metadata while their executable initialization and captured-environment construction remain blocked.Dependent member/prototype operations produce explicit unsupported values. Receiver checks cover union/intersection types, apparent types, generic constraints, nullable receivers and transparent casts. Own data fields remain accessible when unevaluated computed string keys cannot redefine them.
Validation:
classes.spec.tsandpartial-class-bodies.spec.ts), including a concrete TypeScript comparison for an independently entered pure body.generateEtsIR→ JSON → JacoDB model integration regressions passed.git diff --checkpassed. No full test suite or new TS200 campaign was run; no concrete coverage or constructor lifecycle support is claimed.This PR targets
neoindependently and changes no USVM code. It does not duplicate the runtime closure-owner fix in #444.