Skip to content

Fix quick_select crashing on non-positive rank in median_of_medians.py #15544

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
Saadanjum0 wants to merge 1 commit into
base: master
Choose a base branch
from
+5 −1
Open

Fix quick_select crashing on non-positive rank in median_of_medians.py #15544

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 5 additions & 1 deletion searches/median_of_medians.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -74,10 +74,14 @@ def quick_select(arr: list, target: int) -> int:
3
>>> quick_select([3, 5, 7, 10, 2, 12], 3)
5
>>> quick_select([2, 4, 5, 7, 899, 54, 32], 0)
-1
>>> quick_select([2, 4, 5, 7, 899, 54, 32], -1)
-1
"""

# Invalid Input
if target > len(arr):
if target <= 0 or target > len(arr):
return -1

# x is the estimated pivot by median of medians algorithm
Expand Down
Loading